[GitHub] [arrow-rs] tustvold edited a comment on pull request #1082: Optimized ByteArrayReader (#1040)

[GitBox <gi...@apache.org>]

tustvold edited a comment on pull request #1082:
URL: https://github.com/apache/arrow-rs/pull/1082#issuecomment-999804838


   > what about performance with primitive types (e.g. int32)
   
   This PR builds on #1054 which yields a 2-6x speed up when using PrimitiveArrayReader on non-nested columns compared to current master. This is purely through better null handling, which this PR also benefits from.
   
   I do have some reservations about drawing too much from these benchmarks, I have found them to have strange interactions with my system's memory allocator, but its certainly not slower and is likely significantly faster.
   
   > compared to old array reader implementation
   
   That's the key thing about #1041 it doesn't replace this array reader implementation, it just adds the ability to extend it. For primitive types the performance of #1041 is therefore [unchanged](https://github.com/apache/arrow-rs/pull/1041#issuecomment-993816497), it just gives the ability to add optimisations such as #1054


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org