You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2018/09/28 13:03:43 UTC
[2/2] hbase git commit: Revert "HBASE-21188 Print heap and gc
informations in our junit ResourceChecker"
Revert "HBASE-21188 Print heap and gc informations in our junit ResourceChecker"
This reverts commit dc1dedb073f390a5cb98bcd1b57358900d69867c.
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/71be251e
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/71be251e
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/71be251e
Branch: refs/heads/master
Commit: 71be251ef27fc8ac5dd6193b736231df2fad5961
Parents: 3baafbe
Author: zhangduo <zh...@apache.org>
Authored: Fri Sep 28 21:03:24 2018 +0800
Committer: zhangduo <zh...@apache.org>
Committed: Fri Sep 28 21:03:24 2018 +0800
----------------------------------------------------------------------
.../hbase/ResourceCheckerJUnitListener.java | 42 --------------------
1 file changed, 42 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/71be251e/hbase-common/src/test/java/org/apache/hadoop/hbase/ResourceCheckerJUnitListener.java
----------------------------------------------------------------------
diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/ResourceCheckerJUnitListener.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/ResourceCheckerJUnitListener.java
index d8df137..225d94f 100644
--- a/hbase-common/src/test/java/org/apache/hadoop/hbase/ResourceCheckerJUnitListener.java
+++ b/hbase-common/src/test/java/org/apache/hadoop/hbase/ResourceCheckerJUnitListener.java
@@ -18,15 +18,12 @@
package org.apache.hadoop.hbase;
-import java.lang.management.ManagementFactory;
-import java.lang.management.MemoryUsage;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.TimeUnit;
import org.apache.hadoop.hbase.ResourceChecker.Phase;
import org.apache.hadoop.hbase.util.JVM;
import org.junit.runner.notification.RunListener;
@@ -142,41 +139,6 @@ public class ResourceCheckerJUnitListener extends RunListener {
}
}
- static class MaxHeapMemoryMBResourceAnalyzer extends ResourceChecker.ResourceAnalyzer {
-
- @Override
- public int getVal(Phase phase) {
- MemoryUsage usage = ManagementFactory.getMemoryMXBean().getHeapMemoryUsage();
- return (int) (usage.getMax() / (1024 * 1024));
- }
- }
-
- static class UsedHeapMemoryMBResourceAnalyzer extends ResourceChecker.ResourceAnalyzer {
-
- @Override
- public int getVal(Phase phase) {
- MemoryUsage usage = ManagementFactory.getMemoryMXBean().getHeapMemoryUsage();
- return (int) (usage.getUsed() / (1024 * 1024));
- }
- }
-
- static class GCCountResourceAnalyzer extends ResourceChecker.ResourceAnalyzer {
-
- @Override
- public int getVal(Phase phase) {
- return Math.toIntExact(ManagementFactory.getGarbageCollectorMXBeans().stream()
- .mapToLong(b -> b.getCollectionCount()).sum());
- }
- }
-
- static class GCTimeSecondResourceAnalyzer extends ResourceChecker.ResourceAnalyzer {
-
- @Override
- public int getVal(Phase phase) {
- return Math.toIntExact(TimeUnit.MILLISECONDS.toSeconds(ManagementFactory
- .getGarbageCollectorMXBeans().stream().mapToLong(b -> b.getCollectionTime()).sum()));
- }
- }
/**
* To be implemented by sub classes if they want to add specific ResourceAnalyzer.
@@ -193,10 +155,6 @@ public class ResourceCheckerJUnitListener extends RunListener {
rc.addResourceAnalyzer(new SystemLoadAverageResourceAnalyzer());
rc.addResourceAnalyzer(new ProcessCountResourceAnalyzer());
rc.addResourceAnalyzer(new AvailableMemoryMBResourceAnalyzer());
- rc.addResourceAnalyzer(new MaxHeapMemoryMBResourceAnalyzer());
- rc.addResourceAnalyzer(new UsedHeapMemoryMBResourceAnalyzer());
- rc.addResourceAnalyzer(new GCCountResourceAnalyzer());
- rc.addResourceAnalyzer(new GCTimeSecondResourceAnalyzer());
addResourceAnalyzer(rc);