[GitHub] [spark] amuraru commented on issue #24618: [SPARK-27734][CORE][SQL] Add memory based thresholds for shuffle spill

[GitBox <gi...@apache.org>]

amuraru commented on issue #24618: [SPARK-27734][CORE][SQL] Add memory based thresholds for shuffle spill
URL: https://github.com/apache/spark/pull/24618#issuecomment-587100884
 
 
   @dongjoon-hyun sorry for dropping the ball here. 
   We have been running this patch in prod with very good results for 1yr+ now - it would be helpful to have it integrated here mainstream..
   
   I rebased on top of `master` and fixed all conflicts.
   Also on 
   > What about TODO: extend existing unit-tests?
   
   I updated all unit-tests but not sure if net new UT are required - the changes are covered well by existing UTs. Let me know what you think.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org