You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by "Erich Schubert (JIRA)" <ji...@apache.org> on 2019/03/29 23:08:00 UTC
[jira] [Comment Edited] (BATIK-1203) ImageTagRegistry forgets to
reinitialize cache
[ https://issues.apache.org/jira/browse/BATIK-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805541#comment-16805541 ]
Erich Schubert edited comment on BATIK-1203 at 3/29/19 11:07 PM:
-----------------------------------------------------------------
Obviously you cannot trigger a bug in the *service file loader* from a svg file.
I have sent you a unit test pull request that triggers the bug: [https://github.com/apache/batik/pull/15]
That makes the bug easily reproducible.
I have made detailed explanations that the cache is not reset correctly in all cases.
I have made a pull request in 2016 alreadywith the trivial fix (remove a line duplicated below, change a return to break): [https://github.com/apache/batik/pull/4]
and now you ask for yet another "end user replication"?
You must be kidding. Apparently you really don't want contributions. You make it REALLY hard. Goodbye.
was (Author: erich.schubert):
Obviously you cannot trigger a bug in the *service file loader* from a svg file.
I have sent you a unit test pull request that triggers the bug: [https://github.com/apache/batik/pull/15]
That makes the bug easily reproducible.
I have made detailed explanations that the cache is not reset correctly in all cases.
I have made a pull request with the trivial fix: [https://github.com/apache/batik/pull/4]
and now you ask for yet another "end user replication"?
You must be kidding. Apparently you really don't want contributions. You make it REALLY hard. Goodbye.
> ImageTagRegistry forgets to reinitialize cache
> ----------------------------------------------
>
> Key: BATIK-1203
> URL: https://issues.apache.org/jira/browse/BATIK-1203
> Project: Batik
> Issue Type: Bug
> Reporter: Erich Schubert
> Priority: Major
>
> Pull request is here:
> https://github.com/apache/batik/pull/4
> ImageTagRegistry fails to clear the cache via:
> extensions = null;
> mimeTypes = null;
> whenever entries are NOT inserted in descending priority. Only if the "if" condition never triggers the cache is correctly reset.
> The reason why this went largely unnoticed is that when the entries are loaded initially, the cache is still null. So it usually gets initialized only once. But because of this bug, you cannot later register a higher-priority handler yourself.
> To test, make sure the cache is populated before calling "register". Then register a low priority entry.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org