You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/12/05 22:21:43 UTC
Review Request 64354: Added tests for UriVolumeProfile module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64354/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jie Yu.
Bugs: MESOS-8251
https://issues.apache.org/jira/browse/MESOS-8251
Repository: mesos
Description
-------
These tests mostly exercise the parsing logic used by the module
and some of the interaction expected from callers of the module
(i.e. the Storage Local Resource Provider).
Diffs
-----
src/Makefile.am 05e8b950a3ee13f7b2e8af9416495f2827138449
src/tests/volume_profile_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/64354/diff/1/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 64354: Added tests for UriVolumeProfile module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64354/
-----------------------------------------------------------
(Updated Dec. 18, 2017, 7:07 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jie Yu.
Changes
-------
Shortened one namespace.
Bugs: MESOS-8251
https://issues.apache.org/jira/browse/MESOS-8251
Repository: mesos
Description
-------
These tests mostly exercise the parsing logic used by the module
and some of the interaction expected from callers of the module
(i.e. the Storage Local Resource Provider).
Diffs (updated)
-----
src/Makefile.am f5a4edd245e8d6535502e951ecaa526c2bae25f9
src/tests/volume_profile_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/64354/diff/5/
Changes: https://reviews.apache.org/r/64354/diff/4-5/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 64354: Added tests for UriVolumeProfile module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64354/
-----------------------------------------------------------
(Updated Dec. 18, 2017, 3:55 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jie Yu.
Changes
-------
Updated test strings (the JSON blobs) to match the scheme change in the previous review.
Bugs: MESOS-8251
https://issues.apache.org/jira/browse/MESOS-8251
Repository: mesos
Description
-------
These tests mostly exercise the parsing logic used by the module
and some of the interaction expected from callers of the module
(i.e. the Storage Local Resource Provider).
Diffs (updated)
-----
src/Makefile.am f5a4edd245e8d6535502e951ecaa526c2bae25f9
src/tests/volume_profile_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/64354/diff/4/
Changes: https://reviews.apache.org/r/64354/diff/3-4/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 64354: Added tests for UriVolumeProfile module.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64354/#review193995
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 15, 2017, 7:29 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64354/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 7:29 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
>
>
> Bugs: MESOS-8251
> https://issues.apache.org/jira/browse/MESOS-8251
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests mostly exercise the parsing logic used by the module
> and some of the interaction expected from callers of the module
> (i.e. the Storage Local Resource Provider).
>
>
> Diffs
> -----
>
> src/Makefile.am f5a4edd245e8d6535502e951ecaa526c2bae25f9
> src/tests/volume_profile_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64354/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 64354: Added tests for UriVolumeProfile module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64354/
-----------------------------------------------------------
(Updated Dec. 15, 2017, 11:29 a.m.)
Review request for mesos, Chun-Hung Hsiao and Jie Yu.
Changes
-------
Update test usage of `--uri` module flag.
Bugs: MESOS-8251
https://issues.apache.org/jira/browse/MESOS-8251
Repository: mesos
Description
-------
These tests mostly exercise the parsing logic used by the module
and some of the interaction expected from callers of the module
(i.e. the Storage Local Resource Provider).
Diffs (updated)
-----
src/Makefile.am f5a4edd245e8d6535502e951ecaa526c2bae25f9
src/tests/volume_profile_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/64354/diff/3/
Changes: https://reviews.apache.org/r/64354/diff/2-3/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 64354: Added tests for UriVolumeProfile module.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64354/#review193229
-----------------------------------------------------------
FAIL: Some Mesos libprocess-tests failed.
Reviews applied: `['64351', '63971', '64352', '64353', '64354']`
Failed command: `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64354
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64354/logs/libprocess-tests-stdout.log):
```
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false" (17011 ms)
[ RUN ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(440): error: Failed to wait 15secs for socket
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true" (16359 ms)
[----------] 4 tests from SSLVerifyIPAdd/SSLTest (34764 ms total)
[----------] Global test environment tear-down
[==========] 223 tests from 35 test cases ran. (262888 ms total)
[ PASSED ] 209 tests.
[ FAILED ] 14 tests, listed below:
[ FAILED ] SSLTest.SSLSocket
[ FAILED ] SSLTest.NonSSLSocket
[ FAILED ] SSLTest.NoVerifyBadCA
[ FAILED ] SSLTest.RequireBadCA
[ FAILED ] SSLTest.VerifyBadCA
[ FAILED ] SSLTest.VerifyCertificate
[ FAILED ] SSLTest.ProtocolMismatch
[ FAILED ] SSLTest.ECDHESupport
[ FAILED ] SSLTest.ValidDowngrade
[ FAILED ] SSLTest.NoValidDowngrade
[ FAILED ] SSLTest.ValidDowngradeEachProtocol
[ FAILED ] SSLTest.NoValidDowngradeEachProtocol
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0, where GetParam() = "false"
[ FAILED ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = "true"
14 FAILED TESTS
YOU HAVE 19 DISABLED TESTS
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64354/logs/libprocess-tests-stderr.log):
```
I1208 08:10:10.685395 7348 process.cpp:887] Failed to accept socket: future discarded
I1208 08:10:10.921784 8 process.cpp:887] Failed to accept socket: future discarded
I1208 08:10:11.852682 6872 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 08:10:11.852682 6872 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 08:10:11.852682 6872 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\V8fwag\cert.pem
I1208 08:10:11.853682 6872 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\V8fwag
I1208 08:10:12.257727 6872 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 08:10:12.257727 6872 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1208 08:10:12.258729 6872 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 08:10:12.305727 6872 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\ocoC0V\cert.pem
I1208 08:10:12.305727 6872 openssl.cpp:566] Using CA dir: C:\Users\mesos\AppData\Local\Temp\ocoC0V
I1208 08:10:13.296145 6872 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1208 08:10:13.296145 6872 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 08:10:13.296145 6872 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 08:10:13.296954 6872 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\MEex88\cert.pem
I1208 08:10:29.707582 6872 openssl.cpp:509] CA directory path unspecified! NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>
I1208 08:10:29.707582 6872 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1208 08:10:29.707582 6872 openssl.cpp:526] Will use IP address verification in subject alternative name certificate extension.
I1208 08:10:29.708582 6872 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1208 08:10:29.708582 6872 openssl.cpp:563] Using CA file: C:\Users\mesos\AppData\Local\Temp\c9s7RI\cert.pem
I1208 08:10:45.953541 7424 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 7, 2017, 10:09 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64354/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 10:09 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
>
>
> Bugs: MESOS-8251
> https://issues.apache.org/jira/browse/MESOS-8251
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests mostly exercise the parsing logic used by the module
> and some of the interaction expected from callers of the module
> (i.e. the Storage Local Resource Provider).
>
>
> Diffs
> -----
>
> src/Makefile.am 05e8b950a3ee13f7b2e8af9416495f2827138449
> src/tests/volume_profile_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64354/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 64354: Added tests for UriVolumeProfile module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64354/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 2:09 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jie Yu.
Changes
-------
Updated to match interface tweaks.
Bugs: MESOS-8251
https://issues.apache.org/jira/browse/MESOS-8251
Repository: mesos
Description
-------
These tests mostly exercise the parsing logic used by the module
and some of the interaction expected from callers of the module
(i.e. the Storage Local Resource Provider).
Diffs (updated)
-----
src/Makefile.am 05e8b950a3ee13f7b2e8af9416495f2827138449
src/tests/volume_profile_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/64354/diff/2/
Changes: https://reviews.apache.org/r/64354/diff/1-2/
Testing
-------
make check
Thanks,
Joseph Wu