[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #16195: [mkldnn-v1.0] Add MKL-DNN activation

[GitBox <gi...@apache.org>]

ciyongch commented on a change in pull request #16195: [mkldnn-v1.0] Add MKL-DNN activation
URL: https://github.com/apache/incubator-mxnet/pull/16195#discussion_r326442272
 
 

 ##########
 File path: src/operator/nn/mkldnn/mkldnn_act-inl.h
 ##########
 @@ -67,8 +63,28 @@ MKLDNNActForward &GetActForward(const ActivationParam& param,
 void MKLDNNActivationForward(const nnvm::NodeAttrs& attrs, const OpContext &ctx,
                              const NDArray &in_data, const OpReqType &req,
                              const NDArray &out_data);
+
+mkldnn::eltwise_backward::primitive_desc GetActBwdDescImpl(
+    const ActivationParam &param, const mkldnn::memory &input_mem,
+    const mkldnn::memory &diff_dst_memory);
+
+class MKLDNNActBackward {
+  std::shared_ptr<mkldnn::eltwise_backward> bwd;
 
 Review comment:
   Make this as a private member? As there's an API `GetBwd()` to retrieve it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services