You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "Daniel Stieglitz (Jira)" <ji...@apache.org> on 2022/11/14 14:44:00 UTC

[jira] [Updated] (NIFI-10813) Complete changes on NIFI Expression Language Unit Testing to be completely JUnit 5

     [ https://issues.apache.org/jira/browse/NIFI-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Stieglitz updated NIFI-10813:
------------------------------------
    Description: In the unit class nifi/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java. I noticed SonarLint is complaining regarding the class being public and the test methods being public since in JUnit 5 they can be anything but private but package level is recommended as it improves the readability of code. This ticket is aimed on making TestQuery.java completely JUnit 5 by removing the public modifiers from the class and its methods.  (was: In the unit class nifi/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java I noticed SonarLint is complaining regarding the class being public and the test methods being public since in JUnit 5 they can be anything but private but package level is recommended as it improves the readability of code. This ticket is aimed on making TestQuery.java completely JUnit 5 by removing the public modifiers from the class and its methods.)

> Complete changes on NIFI Expression Language Unit Testing to be completely JUnit 5
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-10813
>                 URL: https://issues.apache.org/jira/browse/NIFI-10813
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>
> In the unit class nifi/nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java. I noticed SonarLint is complaining regarding the class being public and the test methods being public since in JUnit 5 they can be anything but private but package level is recommended as it improves the readability of code. This ticket is aimed on making TestQuery.java completely JUnit 5 by removing the public modifiers from the class and its methods.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)