You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Volker Weber <v....@inexso.de> on 2007/02/15 12:46:37 UTC

Re: svn commit: r507879 - in /myfaces/tomahawk/trunk: core/src/main/java/org/apache/myfaces/custom/calendar/ sandbox/core/src/main/java/org/apache/myfaces/custom/conversation/ sandbox/core/src/main/java/org/apache/myfaces/custom/focus/ sandbox/core/s

Hi mario,

for which reason can the normal findComponent fail?

I don't think this approach is a good idea.
This supports user in being careless in setting id's.

Regards,
  Volker


2007/2/15, imario@apache.org <im...@apache.org>:
> Author: imario
> Date: Thu Feb 15 02:36:45 2007
> New Revision: 507879
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=507879
> Log:
> added findDeepComponentById to ComponentUtils. Using it in s:focus and s:submitOnEvent as "fallback" if normal findComponent failes

Re: svn commit: r507879 - in /myfaces/tomahawk/trunk: core/src/main/java/org/apache/myfaces/custom/calendar/ sandbox/core/src/main/java/org/apache/myfaces/custom/conversation/ sandbox/core/src/main/java/org/apache/myfaces/custom/focus/ sandbox/core/s

Posted by Martin Marinschek <ma...@gmail.com>.
no, no, it's not a bug - it's a divine feature ;)

regards,

Martin

On 2/15/07, Matthias Wessendorf <ma...@apache.org> wrote:
> the holly IDE has a bug ???
>
> On 2/15/07, Mario Ivankovits <ma...@ops.co.at> wrote:
> > Hi Volker!
> > > for which reason can the normal findComponent fail?
> > >
> > > I don't think this approach is a good idea.
> > > This supports user in being careless in setting id's.
> > Ok, I think you are right, I've reverted it.
> > Now I've to file a bug for Intellij IDEA as they do not honor
> > NaminContainer and so these for settings are considered wrong (red code) :-(
> >
> > Ciao,
> > Mario
> >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>


-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Re: svn commit: r507879 - in /myfaces/tomahawk/trunk: core/src/main/java/org/apache/myfaces/custom/calendar/ sandbox/core/src/main/java/org/apache/myfaces/custom/conversation/ sandbox/core/src/main/java/org/apache/myfaces/custom/focus/ sandbox/core/s

Posted by Matthias Wessendorf <ma...@apache.org>.
the holly IDE has a bug ???

On 2/15/07, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi Volker!
> > for which reason can the normal findComponent fail?
> >
> > I don't think this approach is a good idea.
> > This supports user in being careless in setting id's.
> Ok, I think you are right, I've reverted it.
> Now I've to file a bug for Intellij IDEA as they do not honor
> NaminContainer and so these for settings are considered wrong (red code) :-(
>
> Ciao,
> Mario
>
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: svn commit: r507879 - in /myfaces/tomahawk/trunk: core/src/main/java/org/apache/myfaces/custom/calendar/ sandbox/core/src/main/java/org/apache/myfaces/custom/conversation/ sandbox/core/src/main/java/org/apache/myfaces/custom/focus/ sandbox/core/s

Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi Volker!
> for which reason can the normal findComponent fail?
>
> I don't think this approach is a good idea.
> This supports user in being careless in setting id's.
Ok, I think you are right, I've reverted it.
Now I've to file a bug for Intellij IDEA as they do not honor
NaminContainer and so these for settings are considered wrong (red code) :-(

Ciao,
Mario


Re: svn commit: r507879 - in /myfaces/tomahawk/trunk: core/src/main/java/org/apache/myfaces/custom/calendar/ sandbox/core/src/main/java/org/apache/myfaces/custom/conversation/ sandbox/core/src/main/java/org/apache/myfaces/custom/focus/ sandbox/core/s

Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi Volker!
> for which reason can the normal findComponent fail?
When the user do not specify the full id of the "for" component but only
the "basename".

If its bad habbit to allow this I'll remove it again. I've found it
comfortable for s:focus and s:submitOnEnter.

Ciao,
Mario