You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/03 12:58:01 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

AngersZhuuuu opened a new pull request #31725:
URL: https://github.com/apache/spark/pull/31725


   
   ### What changes were proposed in this pull request?
   Remove unused output of AddJarCommand, keep consistence and clean
   
   ### Why are the changes needed?
   Keep consistence and clean
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Not need
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789716417


   Is the output really unused anywhere? if it's used at all, like displayed somewhere, maybe worth keeping


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789815185


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40294/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31725:
URL: https://github.com/apache/spark/pull/31725


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789701517


   **[Test build #135711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135711/testReport)** for PR 31725 at commit [`12f63a7`](https://github.com/apache/spark/commit/12f63a775af2023568c966cf8cc4dd7ad55e42a5).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789729520


   **[Test build #135712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135712/testReport)** for PR 31725 at commit [`e978e41`](https://github.com/apache/spark/commit/e978e41439c1f053a58ee92dbd60aa890f06fe90).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789815185


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40294/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789894720


   Seems OK if so, AFAIK


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789719220


   > Is the output really unused anywhere? if it's used at all, like displayed somewhere, maybe worth keeping
   
   I have check many command that return `Seq.empty[Row]`, they don't need output. And we can see `AddFileCommand` don't have too, also `AddArchiveCommand` https://github.com/apache/spark/pull/31721
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789944341


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135712/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789701553






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789697854


   **[Test build #135711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135711/testReport)** for PR 31725 at commit [`12f63a7`](https://github.com/apache/spark/commit/12f63a775af2023568c966cf8cc4dd7ad55e42a5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789944341


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135712/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789701624


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40293/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789937917


   **[Test build #135712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135712/testReport)** for PR 31725 at commit [`e978e41`](https://github.com/apache/spark/commit/e978e41439c1f053a58ee92dbd60aa890f06fe90).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789697854


   **[Test build #135711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135711/testReport)** for PR 31725 at commit [`12f63a7`](https://github.com/apache/spark/commit/12f63a775af2023568c966cf8cc4dd7ad55e42a5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789729520


   **[Test build #135712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135712/testReport)** for PR 31725 at commit [`e978e41`](https://github.com/apache/spark/commit/e978e41439c1f053a58ee92dbd60aa890f06fe90).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789701553


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135711/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31725: [SPARK-34608][SQL] Remove unused output of AddJarCommand

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31725:
URL: https://github.com/apache/spark/pull/31725#issuecomment-789701613


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40293/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org