svn commit: r950101 - in /shindig/trunk/features/src/main/javascript/features/container: gadget_site.js service.js

[li...@apache.org]

Author: lindner
Date: Tue Jun  1 15:09:23 2010
New Revision: 950101

URL: http://svn.apache.org/viewvc?rev=950101&view=rev
Log:
minor cleanups

Modified:
    shindig/trunk/features/src/main/javascript/features/container/gadget_site.js
    shindig/trunk/features/src/main/javascript/features/container/service.js

Modified: shindig/trunk/features/src/main/javascript/features/container/gadget_site.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/gadget_site.js?rev=950101&r1=950100&r2=950101&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/gadget_site.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container/gadget_site.js Tue Jun  1 15:09:23 2010
@@ -156,7 +156,7 @@ shindig.container.GadgetSite.prototype.g
  * Returns configuration of a feature with a given name. Defaults to current
  * loading or visible gadget if no metadata is passed in.
  * @param {string} name Name of the feature.
- * @param {Object} opt_gadgetInfo Optional gadget info.
+ * @param {Object=} opt_gadgetInfo Optional gadget info.
  * @return {Object} JSON representing the feature.
  */
 shindig.container.GadgetSite.prototype.getFeature = function(name, opt_gadgetInfo) {
@@ -168,7 +168,7 @@ shindig.container.GadgetSite.prototype.g
 /**
  * Returns the loading or visible gadget with the given ID.
  * @param {string} id The iframe ID of gadget to return.
- * @return {shindig.container.GadgetHolder} The gadget. Null, if not exist.
+ * @return {shindig.container.GadgetHolder?} The gadget. Null, if not exist.
  */
 shindig.container.GadgetSite.prototype.getGadgetHolder = function(id) {
   if (this.curGadget_ && this.curGadget_.getIframeId() == id) {

Modified: shindig/trunk/features/src/main/javascript/features/container/service.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/service.js?rev=950101&r1=950100&r2=950101&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/service.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container/service.js Tue Jun  1 15:09:23 2010
@@ -32,8 +32,8 @@ shindig.container.Service = function(opt
   /**
    * @type {boolean}
    */
-  this.sameDomain_ = shindig.container.util.getSafeJsonValue(config,
-      shindig.container.ServiceConfig.SAME_DOMAIN, true);
+  this.sameDomain_ = Boolean(shindig.container.util.getSafeJsonValue(config,
+      shindig.container.ServiceConfig.SAME_DOMAIN, true));
 
   this.onConstructed(config);
 };
@@ -93,10 +93,12 @@ shindig.container.Service.prototype.proc
 // -----------------------------------------------------------------------------
 
 /**
- * Enumeation of configuration keys for this service. This is specified in
+ * Enumeration of configuration keys for this service. This is specified in
  * JSON to provide extensible configuration.
  * @enum {string}
  */
 shindig.container.ServiceConfig = {};
+
 //Toggle to render gadgets in the same domain.
+/** @type {string} */
 shindig.container.ServiceConfig.SAME_DOMAIN = 'sameDomain';