You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ex00 <gi...@git.apache.org> on 2017/02/09 07:57:21 UTC

[GitHub] flink pull request #3012: [FLINK-2186] Add readCsvAsRow methods to CsvReader...

Github user ex00 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3012#discussion_r100247839
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java ---
    @@ -192,6 +193,28 @@ public void getFlatFields(String fieldExpression, int offset, List<FlatFieldDesc
     		}
     	}
     
    +	public RowTypeInfo(TypeInformation<?> mainType, int size, Map<Integer, TypeInformation<?>> additionalTypes) {
    +		this(configureTypes(mainType, size, additionalTypes));
    +	}
    +
    +	public RowTypeInfo(TypeInformation<?> mainType, int size) {
    +		this(configureTypes(mainType, size, Collections.<Integer, TypeInformation<?>>emptyMap()));
    +	}
    +
    +	private static TypeInformation<?>[] configureTypes(TypeInformation<?> mainType, int size, Map<Integer, TypeInformation<?>> additionalTypes) {
    --- End diff --
    
    Could you format argumets like as for ```RowTypeInfo#createComparator#219```
    for example:
    ```
    private static TypeInformation<?>[] configureTypes(
    		TypeInformation<?> mainType,
    		int size,
    		Map<Integer, TypeInformation<?>> additionalTypes) {
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---