You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "MichaelChirico (via GitHub)" <gi...@apache.org> on 2026/05/21 15:14:44 UTC
[PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
MichaelChirico opened a new pull request, #50015:
URL: https://github.com/apache/arrow/pull/50015
I opted to delete the 'reexports' file because the symbols are not _actually_ re-exported. IMHO, it's more appropriate to just add this hook in arrow-package.R as done here, but of course if your strong preference is to retain the reexports-bit64.R file I'll restore it.
`integer64()` should be a fine choice -- I basically wanted a part of the API that has essentially 0 chance of ever changing.
As of today, `R CMD check` doesn't complain if you import a symbol and then don't reference it in the sources. Nor do I think such a check will ever happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "MichaelChirico (via GitHub)" <gi...@apache.org>.
MichaelChirico commented on PR #50015:
URL: https://github.com/apache/arrow/pull/50015#issuecomment-4511207416
OK, I managed to install with `cmake` finally. I adapted the original bug report given the update in arrow API, please double-check it's done faithfully:
```r
# NB: IIUC, as_vector() and/or arrow_array() will
# not retain 64-bit representation of the original 1:10,
# so force that with a non-32-bit input
x = lim.integer64()
a <- arrow_array(x)
a$as_vector()
# integer64
# [1] -9223372036854775807 9223372036854775807
detach("package:bit64", unload = TRUE)
# Warning message:
# ‘bit64’ namespace cannot be unloaded:
# namespace ‘bit64’ is imported by ‘arrow’ so cannot be unloaded
```
Is it recommended to put this in a test? The most natural way to do so would be a new file in r/tests reproducing the above -- I am a bit loath to put a `detach()` in the testthat suite. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #50015:
URL: https://github.com/apache/arrow/pull/50015#issuecomment-4513785821
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50015:
URL: https://github.com/apache/arrow/pull/50015#issuecomment-4522449239
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 96f80729c1581ee98f9d0a2cd9994ae50302491d.
There were 3 benchmark results with an error:
- Commit Run on `amd64-m5-4xlarge-linux` at [2026-05-22 14:38:45Z](https://conbench.arrow-dev.org/runs/1c3c3ffc58ce4da8a4859c0ece7fa5ed)
- [file-read](https://conbench.arrow-dev.org/benchmark-results/06a107ea7848764180001c1c6c5956f9)
- [csv-read](https://conbench.arrow-dev.org/benchmark-results/06a10685e8f97d3480009766c0432de0)
- and 1 more (see the report linked below)
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/77455968284) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50015:
URL: https://github.com/apache/arrow/pull/50015#issuecomment-4509659087
:warning: GitHub issue #50014 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50015:
URL: https://github.com/apache/arrow/pull/50015#issuecomment-4513798351
Revision: 16c745954862b88206b7102bc2590ac2031c9eed
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ccf035b329](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ccf035b329)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488867/job/77292630841)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487865/job/77292627919)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487953/job/77292628071)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487531/job/77292627124)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488571/job/77292629905)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487640/job/77292627232)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487230/job/77292626164)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487895/job/77292628044)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488011/job/77292628406)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487934/job/77292628005)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488277/job/77292629154)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487596/job/77292627127)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488432/job/77292629511)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487171/job/77292626475)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488596/job/77292629992)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487704/job/77292627317)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487961/job/77292628154)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488255/job/77292629014)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488760/job/77292630436)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/26260489007/job/77292631325)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/26260487670/job/77292627280)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488354/job/77292629323)|
|test-r-wasm|[](https://github.com/ursacomputing/crossbow/actions/runs/26260488715/job/77292630318)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane merged PR #50015:
URL: https://github.com/apache/arrow/pull/50015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50015:
URL: https://github.com/apache/arrow/pull/50015#issuecomment-4509658961
:warning: GitHub issue #50014 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "MichaelChirico (via GitHub)" <gi...@apache.org>.
MichaelChirico commented on PR #50015:
URL: https://github.com/apache/arrow/pull/50015#issuecomment-4509763595
The GitHub codespace where I edited this doesn't have enough resources to compile {arrow} reliably :\
So I can't re-run the test of attempting to detach {bit64} with an existing integer64 column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50014: [R] Replace imported symbol from bit64 [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #50015:
URL: https://github.com/apache/arrow/pull/50015#discussion_r3285047625
##########
r/R/reexports-bit64.R:
##########
@@ -1,22 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I'm ok with removing the reexports file here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org