You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2023/11/13 08:11:51 UTC
[PR] [CELEBORN-1124] Exclude workers of shuffle manager always remove worker of connect exception replica [incubator-celeborn]
SteNicholas opened a new pull request, #2091:
URL: https://github.com/apache/incubator-celeborn/pull/2091
### What changes were proposed in this pull request?
Exclude workers of shuffle manager remove worker of connect exception primary and replica.
### Why are the changes needed?
Exclude workers of shuffle manager should not always remove worker of connect exception replica.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1124] Exclude workers of shuffle manager remove worker of connect exception primary or replica [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2091:
URL: https://github.com/apache/incubator-celeborn/pull/2091#issuecomment-1807661174
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2091?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2091](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2091?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bc7717c) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/3c6e4697f3270298ea3dc2549f2979be0854fbc4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3c6e469) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #2091 +/- ##
==========================================
- Coverage 46.76% 46.65% -0.10%
==========================================
Files 166 166
Lines 10695 10695
Branches 977 977
==========================================
- Hits 5000 4989 -11
- Misses 5373 5384 +11
Partials 322 322
```
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2091/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1124] Exclude workers of shuffle manager remove worker of connect exception primary or replica [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady closed pull request #2091: [CELEBORN-1124] Exclude workers of shuffle manager remove worker of connect exception primary or replica
URL: https://github.com/apache/incubator-celeborn/pull/2091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1124] Exclude workers of shuffle manager remove worker of connect exception primary or replica [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2091:
URL: https://github.com/apache/incubator-celeborn/pull/2091#issuecomment-1807764836
thanks, merging to main(v0.4.0)/branch-0.3(v0.3.2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org