[GitHub] [iceberg] kbendick commented on a change in pull request #2680: Core: Add RocksDBStructLikeMap

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #2680:
URL: https://github.com/apache/iceberg/pull/2680#discussion_r763590970



##########
File path: build.gradle
##########
@@ -220,6 +220,7 @@ project(':iceberg-core') {
     compile "com.fasterxml.jackson.core:jackson-databind"
     compile "com.fasterxml.jackson.core:jackson-core"
     compile "com.github.ben-manes.caffeine:caffeine"
+    compile "org.rocksdb:rocksdbjni"

Review comment:
       That makes sense.
   
   I'd advocate for possibly sharing it though, so that multiple versions can exist together.
   
   With Spark 3.2 bringing support for RocksDB statestore as well, it might be wise to shade it in the finl outcome. But that is admittedly a long ways off.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org