You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/10/13 20:31:18 UTC
[GitHub] [yunikorn-release] DerekTBrown opened a new pull request, #110: Fix(YUNICORN-1261): Add pre-upgrade hook
DerekTBrown opened a new pull request, #110:
URL: https://github.com/apache/yunikorn-release/pull/110
I believe `YUNICORN-1261` is caused because we are missing a lifecycle hook for upgrades:
https://helm.sh/docs/topics/charts_hooks/#the-available-hooks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit commented on pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #110:
URL: https://github.com/apache/yunikorn-release/pull/110#issuecomment-1320268836
Closing this as we resolved in a different way in https://issues.apache.org/jira/browse/YUNIKORN-1221.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] craigcondit closed pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
URL: https://github.com/apache/yunikorn-release/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] DerekTBrown commented on pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
Posted by GitBox <gi...@apache.org>.
DerekTBrown commented on PR #110:
URL: https://github.com/apache/yunikorn-release/pull/110#issuecomment-1279475756
@wilfred-s I apologize- I put this up-for-review prematurely.
I think YuniKorn is in a highly similar place to Spark Operator in terms of Helm hooks:
https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/1624
What we really need is first-order support for resource ordering. Unfortunately, the hooks have weird semantics that make it hard for us to get the desired behavior.
I am going to wait for the conversation in https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/pull/1624
to resolve, and then we can decide whether we want to adopt this same approach within YuniKorn. The Spark Operator only has 3 instances of the hook, whereas I see 12 in YuniKorn, so this might be more heavy-handed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org
[GitHub] [yunikorn-release] wilfred-s commented on pull request #110: [YUNIKORN-1261] Add pre-upgrade hook
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #110:
URL: https://github.com/apache/yunikorn-release/pull/110#issuecomment-1278322727
By adding a pre-upgrade hook could we be triggering a `resource exists` error causing the upgrade to fail? Or are we relying on the default hook deletion policy `before-hook-creation`?
One last question: has this been tested and how?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org