[jira] Commented: (SLING-985) Allow ATOM Syndication Format output

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717261#action_12717261 ] 

Felix Meschberger commented on SLING-985:
-----------------------------------------

Thanks for providing this patch. I have applied it slightly modified in Rev. 782630.

The modifications include:

  * Reformat to replace all tabs by spaces
  * Set version number to 0.9.0-incubator-SNAPSHOT
  * Added serial version uids

Now for setting up the Abdera instance: You check for a request attribute named "abdera" and if this attribute does not exist, you create an instance and setup the factory. I wonder:

   * Is it required to have an Abdera instance per request ?
   * How leightweight is the creation of the Abdera instance  or can the instance be shared ?
   * You have a stray "new FOMFactory()" statement in the getAbdera method. Is this required ?
   * Setting up the factory on each request looks wrong. Can you do this in a BundleActivator once and for all ?

Now, you write in the comment, that setting up the factory is "broken" in the OSGi-fied Abdera libraries. Can this be fixed somehow, for example by adding a BundleActivator to the factory provider bundles or by adding code to the Abdera core to collect bundles providing factories ? I agree, that is completely wrong to have the taglib set up the factories.

> Allow ATOM Syndication Format output
> ------------------------------------
>
>                 Key: SLING-985
>                 URL: https://issues.apache.org/jira/browse/SLING-985
>             Project: Sling
>          Issue Type: New Feature
>            Reporter: Lars Trieloff
>            Assignee: Felix Meschberger
>            Priority: Minor
>         Attachments: SLING-985.patch
>
>
> Having a JSON output for Sling is quite nice, but many web applications require RSS/Atom support these days. Having an extension module that provides a tag library for creating Atom feeds and atom entries out of JCR nodes would be very helpful.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.