You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by "Ash, Bryan" <Br...@arrisi.com> on 2010/10/28 17:00:45 UTC
Patch Request for Batik Rasterizer
Developers:
I am currently working on an application that is utilizing Batik Rasterizer for exporting our graphic data. I have noticed that a module used for JPEG exporting (specifically JPEGImageWriter in package org.apache.batik.ext.awt.image.codec.jpeg) uses Sun's proprietary packages com.sun.*.
In most cases, this seems fine. However, in a recent revision of OpenJDK shipped on Ubuntu systems, they have updated some interfaces to now be classes. Since Sun has the disclaimer that they are allowed to change code located in these packages without warning, we are at the mercy of what they choose to do.
I would like to submit a patch, rewriting the module to use java.* and javax.* instead of com.sun*, assuming the process hasn't already been started by someone else.
Please reply at your earliest convenience and let me know if this is still a maintained application, and what process you have for patch submissions.
Best Regards
---------------------------
Bryan Ash
Software Developer
Arris Group, Inc.
---------------------------
Re: Patch Request for Batik Rasterizer
Posted by "Bates, Chris" <Ch...@arrisi.com>.
David,
Thank you for your quick response that does look like the problem we are seeing, Ill double check the version we are using today and get back to you.
------------------------
Christopher Bates
Software Architect
Arris Group, Inc.
------------------------
On Oct 28, 2010, at 11:57 AM, David Wimsey wrote:
https://issues.apache.org/bugzilla/show_bug.cgi?id=46513
On Oct 28, 2010, at 11:37 AM, David Wimsey wrote:
Are you using the latest revision from the subversion repository (1.8-PRE)? I can't find any com.sun.* references in a quick search. I'm pretty sure those issues were fixed some time ago, as I seem to recall some other bugs that popped up after the switch over.
On Oct 28, 2010, at 11:00 AM, Ash, Bryan wrote:
Developers:
I am currently working on an application that is utilizing Batik Rasterizer for exporting our graphic data. I have noticed that a module used for JPEG exporting (specifically JPEGImageWriter in package org.apache.batik.ext.awt.image.codec.jpeg) uses Sun’s proprietary packages com.sun.*.
In most cases, this seems fine. However, in a recent revision of OpenJDK shipped on Ubuntu systems, they have updated some interfaces to now be classes. Since Sun has the disclaimer that they are allowed to change code located in these packages without warning, we are at the mercy of what they choose to do.
I would like to submit a patch, rewriting the module to use java.* and javax.* instead of com.sun*, assuming the process hasn’t already been started by someone else.
Please reply at your earliest convenience and let me know if this is still a maintained application, and what process you have for patch submissions.
Best Regards
---------------------------
Bryan Ash
Software Developer
Arris Group, Inc.
---------------------------
Re: Patch Request for Batik Rasterizer
Posted by David Wimsey <dw...@rtsz.com>.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46513
On Oct 28, 2010, at 11:37 AM, David Wimsey wrote:
> Are you using the latest revision from the subversion repository (1.8-PRE)? I can't find any com.sun.* references in a quick search. I'm pretty sure those issues were fixed some time ago, as I seem to recall some other bugs that popped up after the switch over.
>
> On Oct 28, 2010, at 11:00 AM, Ash, Bryan wrote:
>
>> Developers:
>>
>> I am currently working on an application that is utilizing Batik Rasterizer for exporting our graphic data. I have noticed that a module used for JPEG exporting (specifically JPEGImageWriter in package org.apache.batik.ext.awt.image.codec.jpeg) uses Sun’s proprietary packages com.sun.*.
>>
>> In most cases, this seems fine. However, in a recent revision of OpenJDK shipped on Ubuntu systems, they have updated some interfaces to now be classes. Since Sun has the disclaimer that they are allowed to change code located in these packages without warning, we are at the mercy of what they choose to do.
>>
>> I would like to submit a patch, rewriting the module to use java.* and javax.* instead of com.sun*, assuming the process hasn’t already been started by someone else.
>>
>> Please reply at your earliest convenience and let me know if this is still a maintained application, and what process you have for patch submissions.
>>
>> Best Regards
>>
>> ---------------------------
>> Bryan Ash
>> Software Developer
>> Arris Group, Inc.
>> ---------------------------
>
Re: Patch Request for Batik Rasterizer
Posted by David Wimsey <dw...@rtsz.com>.
Are you using the latest revision from the subversion repository (1.8-PRE)? I can't find any com.sun.* references in a quick search. I'm pretty sure those issues were fixed some time ago, as I seem to recall some other bugs that popped up after the switch over.
On Oct 28, 2010, at 11:00 AM, Ash, Bryan wrote:
> Developers:
>
> I am currently working on an application that is utilizing Batik Rasterizer for exporting our graphic data. I have noticed that a module used for JPEG exporting (specifically JPEGImageWriter in package org.apache.batik.ext.awt.image.codec.jpeg) uses Sun’s proprietary packages com.sun.*.
>
> In most cases, this seems fine. However, in a recent revision of OpenJDK shipped on Ubuntu systems, they have updated some interfaces to now be classes. Since Sun has the disclaimer that they are allowed to change code located in these packages without warning, we are at the mercy of what they choose to do.
>
> I would like to submit a patch, rewriting the module to use java.* and javax.* instead of com.sun*, assuming the process hasn’t already been started by someone else.
>
> Please reply at your earliest convenience and let me know if this is still a maintained application, and what process you have for patch submissions.
>
> Best Regards
>
> ---------------------------
> Bryan Ash
> Software Developer
> Arris Group, Inc.
> ---------------------------
Re: Patch Request for Batik Rasterizer
Posted by Simon Pepping <sp...@leverkruid.eu>.
On Sun, Nov 14, 2010 at 06:31:27PM +0000, Helder Magalhães wrote:
> Hi Bryan,
>
>
> > Developers:
> >
> > I am currently working on an application that is utilizing Batik Rasterizer
> > for exporting our graphic data. I have noticed that a module used for JPEG
> > exporting (specifically JPEGImageWriter in package
> > org.apache.batik.ext.awt.image.codec.jpeg) uses Sun’s proprietary packages
> > com.sun.*.
>
> Right, David Wimsey has already pointed out to the specific bug your
> are suffering. ;-)
>
>
> > In most cases, this seems fine. However, in a recent revision of OpenJDK
> > shipped on Ubuntu systems, they have updated some interfaces to now be
> > classes. Since Sun has the disclaimer that they are allowed to change code
> > located in these packages without warning, we are at the mercy of what they
> > choose to do.
>
> Please take a look at the issue. There are pointers there towards
> using not only OpenJDK but also GNU ClassPath, IcedTea (which AFAIK is
> the previous name of OpenJDK), etc.
>
>
> > I would like to submit a patch, rewriting the module to use java.* and
> > javax.* instead of com.sun*, assuming the process hasn’t already been
> > started by someone else.
The same problem was dealt with in xmlgraphics-commons, see r1028385,
http://svn.apache.org/viewvc?view=revision&sortby=file&revision=1028385.
The idea is that batik eventually will depend on xmlgraphics-commons,
but that will take a while (and a release).
Simon
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
Re: Patch Request for Batik Rasterizer
Posted by Helder Magalhães <he...@gmail.com>.
Hi Bryan,
> Developers:
>
> I am currently working on an application that is utilizing Batik Rasterizer
> for exporting our graphic data. I have noticed that a module used for JPEG
> exporting (specifically JPEGImageWriter in package
> org.apache.batik.ext.awt.image.codec.jpeg) uses Sun’s proprietary packages
> com.sun.*.
Right, David Wimsey has already pointed out to the specific bug your
are suffering. ;-)
> In most cases, this seems fine. However, in a recent revision of OpenJDK
> shipped on Ubuntu systems, they have updated some interfaces to now be
> classes. Since Sun has the disclaimer that they are allowed to change code
> located in these packages without warning, we are at the mercy of what they
> choose to do.
Please take a look at the issue. There are pointers there towards
using not only OpenJDK but also GNU ClassPath, IcedTea (which AFAIK is
the previous name of OpenJDK), etc.
> I would like to submit a patch, rewriting the module to use java.* and
> javax.* instead of com.sun*, assuming the process hasn’t already been
> started by someone else.
Patches are always welcome, thanks for considering that possibility! ;-)
> Please reply at your earliest convenience and let me know if this is still a
> maintained application, and what process you have for patch submissions.
Earliest is the problem here, as the whole committer team is pretty
overflowed and stuff isn't getting lost but is surely getting delayed
quite a bit. :-|
Yes, this is a maintained application, and no, features have not been
lately added as fast as one might want (although you have several nice
features in the bug tracker, waiting to be integrated - would you
consider helping in that as well? :-) )
The procedure is typically to report bugs and attach patches to the
bug report when possible. However in this case, I'd add that:
1. No need to report the bug, that's already done (bug 46513, as
already stated above and by David);
2. Jeremias Maerki has recently done this in the scope of FOP using
XmlGraphicsCommons. He's considering [1] doing just that to Batik as
well, but that wasn't yet possible.
3. I do also already have an untested patch in my working copy which
does more or less that, although I didn't yet attach it to the bug
report because I really wanted to check it worked (I really should
have already attach a work-in-progress patch for you to help
validating, and even to possibly help Jeremias in his effort).
> Best Regards
>
> ---------------------------
> Bryan Ash
> Software Developer
> Arris Group, Inc.
> ---------------------------
Hope this helps,
Helder
[1] http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/201010.mbox/browser#msg-20
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org