You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jacek Laskowski <jl...@apache.org> on 2005/08/23 09:23:27 UTC
Re: svn commit: r234422 - in /geronimo/trunk: applications/console-core/src/java/org/apache/geronimo/console/util/
applications/console-framework/src/webapp/WEB-INF/data/ applications/console-standard/src/java/org/apache/geronimo/console/
applications/cons...
ammulder@apache.org wrote:
> Author: ammulder
> Date: Sun Aug 21 20:26:39 2005
> New Revision: 234422
>
> URL: http://svn.apache.org/viewcvs?rev=234422&view=rev
Hi Aaron,
I don't like the license hell, so whenever I see a change in a license
I'd better ask before accepting it.
> Added: geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/BasePortlet.java
> URL: http://svn.apache.org/viewcvs/geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/BasePortlet.java?rev=234422&view=auto
> ==============================================================================
> --- geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/BasePortlet.java (added)
> +++ geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/BasePortlet.java Sun Aug 21 20:26:39 2005
> @@ -0,0 +1,92 @@
> +/**
> + *
> + * Copyright 2004, 2005 The Apache Software Foundation or its licensors, as applicable.
I don't understand the rest after The Apache Software Foundation. Did I
miss when we decided to use such a copyright?
> Added: geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/server/BaseJMSPortlet.java
> URL: http://svn.apache.org/viewcvs/geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/server/BaseJMSPortlet.java?rev=234422&view=auto
> ==============================================================================
> --- geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/server/BaseJMSPortlet.java (added)
> +++ geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/server/BaseJMSPortlet.java Sun Aug 21 20:26:39 2005
> @@ -0,0 +1,51 @@
> +/**
> + *
> + * Copyright 2003-2004 The Apache Software Foundation
I first thought that if I had missed the change in the license header it
would have been applied to all classes in applications/console-*. It
seems to be not the case. Why is that?
Since it's a new file - BaseJMSPortlet - shouldn't the year be changed
to 2005 only?
Jacek
Re: svn commit: r234422 - in /geronimo/trunk:
applications/console-core/src/java/org/apache/geronimo/console/util/
applications/console-framework/src/webapp/WEB-INF/data/
applications/console-standard/src/java/org/apache/geronimo/console/
applications/cons...
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
The answer to all of the below is that I copy and pasted a header
from some file that had one into the new files I created. So any errors
or variations weren't intentional, but because they were present in the
files I copied from. :)
Aaron
On Tue, 23 Aug 2005, Jacek Laskowski wrote:
> ammulder@apache.org wrote:
> > Author: ammulder
> > Date: Sun Aug 21 20:26:39 2005
> > New Revision: 234422
> >
> > URL: http://svn.apache.org/viewcvs?rev=234422&view=rev
>
> Hi Aaron,
>
> I don't like the license hell, so whenever I see a change in a license
> I'd better ask before accepting it.
>
> > Added: geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/BasePortlet.java
> > URL: http://svn.apache.org/viewcvs/geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/BasePortlet.java?rev=234422&view=auto
> > ==============================================================================
> > --- geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/BasePortlet.java (added)
> > +++ geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/BasePortlet.java Sun Aug 21 20:26:39 2005
> > @@ -0,0 +1,92 @@
> > +/**
> > + *
> > + * Copyright 2004, 2005 The Apache Software Foundation or its licensors, as applicable.
>
> I don't understand the rest after The Apache Software Foundation. Did I
> miss when we decided to use such a copyright?
>
> > Added: geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/server/BaseJMSPortlet.java
> > URL: http://svn.apache.org/viewcvs/geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/server/BaseJMSPortlet.java?rev=234422&view=auto
> > ==============================================================================
> > --- geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/server/BaseJMSPortlet.java (added)
> > +++ geronimo/trunk/applications/console-standard/src/java/org/apache/geronimo/console/jmsmanager/server/BaseJMSPortlet.java Sun Aug 21 20:26:39 2005
> > @@ -0,0 +1,51 @@
> > +/**
> > + *
> > + * Copyright 2003-2004 The Apache Software Foundation
>
> I first thought that if I had missed the change in the license header it
> would have been applied to all classes in applications/console-*. It
> seems to be not the case. Why is that?
>
> Since it's a new file - BaseJMSPortlet - shouldn't the year be changed
> to 2005 only?
>
> Jacek
>
>