[PR] [C++] Preserve TableSchema state during moves [tsfile]

["zhangxinyao88 (via GitHub)" <gi...@apache.org>]

zhangxinyao88 opened a new pull request, #1032:
URL: https://github.com/apache/tsfile/pull/1032

   Moving a valid `TableSchema` drops `column_pos_index_`, so `TsFileWriter::register_table` rejects it as if it had duplicate columns. The move also resets the virtual-table flag and pending tree depth, changing case-sensitive lookups and losing generated tree-level tag columns.
   
   Default the move constructor so every member is transferred. Add regressions for registration followed by a write/read round trip, duplicate-column rejection, virtual-table lookup semantics, and tree-level finalization after a move. Four regressions fail on current develop; the duplicate-name rejection control already passes.
   
   Part of #468, bug20. The other findings in that aggregate report remain separate.
   
   Validation:
   - `./mvnw -B -ntp -P with-cpp -Denable.lzma2=ON verify`: 1,168 passed, 3 skipped, 10 disabled, 0 failed; Spotless, Checkstyle and RAT passed.
   - All five focused cases pass under ASan/UBSan with `halt_on_error=1`. Compiler flags and sanitizer runtime linkage were verified. This separate Debug build disables optional codecs, ANTLR and SIMD; the complete Maven run above enables them, including LZMA2.
   
   Java, Python and local Windows/MSVC tests were not run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [C++] Preserve TableSchema state during moves [tsfile]

["ColinLeeo (via GitHub)" <gi...@apache.org>]

ColinLeeo commented on PR #1032:
URL: https://github.com/apache/tsfile/pull/1032#issuecomment-6407649247

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [C++] Preserve TableSchema state during moves [tsfile]

["ColinLeeo (via GitHub)" <gi...@apache.org>]

ColinLeeo merged PR #1032:
URL: https://github.com/apache/tsfile/pull/1032


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org