[jira] Commented: (SLING-559) Request parameter re-encoding does not work

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608363#action_12608363 ] 

Felix Meschberger commented on SLING-559:
-----------------------------------------

Re-encoding is in fact not performed (my bad) because the Util.fixEncoding method checks for the existence of a parameter's encoding before trying to set the encoding. In reality the encoding should be checked for existence _and_ for being the same as the actual encoding to be used. Only if the encoding is already set to the correct encoding, does the parameter not need to be re-encoded.

> Request parameter re-encoding does not work
> -------------------------------------------
>
>                 Key: SLING-559
>                 URL: https://issues.apache.org/jira/browse/SLING-559
>             Project: Sling
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: Engine 2.0.2
>            Reporter: Tobias Bocanegra
>            Assignee: Felix Meschberger
>
> Issue SLING-508 introduced a smart way to re-encode request parameters, if they are sent in a different encoding that the default.
> imo there is a bug that causes this functionality to fail:
> in ParameterSupport.getContainerParameters(....) new ContainerRequestParameter are generated with the respective encoding. but the
> constructor does never call setEncoding() and the re-encode is never performed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.