Embracing AssertJ

[Jeremy Daggett <je...@RACKSPACE.COM>]

Hi devs,

I had a lot of fun writing some tests using AssertJ yesterday. Rather than specifying it in each project pom, I propose that we add the following libraries to the root project pom dependencies:

- assertj-core
- assertj-guava

Any objections?

I am experimenting with the assertions generator to see if we can take advantage of it for generating assertions, which could be extremely useful. I wish I had this years ago!

Lastly, I want to give a shout out to Andrew Gaul for the contribution of the ByteSourceAssert class in the assertj-guava library. Thanks Andrew!

/jd

Re: Embracing AssertJ

[Jeremy Daggett <je...@RACKSPACE.COM>]

Great! I will submit a PR with the changes I made to the pom. I agree that
assertj should *only* be in test scope, and that is how I currently have
it configured. 

/jd

On 9/16/14, 12:34 PM, "Andrew Gaul" <ga...@apache.org> wrote:

>On Tue, Sep 16, 2014 at 07:51:48PM +0200, Andrew Phillips wrote:
>> >- assertj-core
>> >- assertj-guava
>> >
>> >Any objections?
>> 
>> Sounds good to me. Do they bring in any libraries that may cause
>> conflicts for our users..?
>
>We should only include assertj with test scope, so jclouds will not
>introduce this dependency for users.  I also support adding assertj as a
>project-wide dependency based on positive experiences using it
>previously and with the glacier provider.
>
>-- 
>Andrew Gaul
>http://gaul.org/

Re: Embracing AssertJ

[Andrew Gaul <ga...@apache.org>]

On Tue, Sep 16, 2014 at 07:51:48PM +0200, Andrew Phillips wrote:
> >- assertj-core
> >- assertj-guava
> >
> >Any objections?
> 
> Sounds good to me. Do they bring in any libraries that may cause
> conflicts for our users..?

We should only include assertj with test scope, so jclouds will not
introduce this dependency for users.  I also support adding assertj as a
project-wide dependency based on positive experiences using it
previously and with the glacier provider.

-- 
Andrew Gaul
http://gaul.org/

Re: Embracing AssertJ

[Jeremy Daggett <je...@RACKSPACE.COM>]

>From the dependencies perspective, we should be OK there:


http://mvnrepository.com/artifact/org.assertj/assertj-core/1.6.1

http://mvnrepository.com/artifact/org.assertj/assertj-guava/1.2.0


We exclude the junit dependency (since we use TestNG), it¹s happy with
Guava, and I just ran full builds of the following repos with no issues:

jclouds
jclouds-chef
jclouds-cli
jclouds-karaf
jclouds-labs-google

jclouds-labs-openstack


/jd

On 9/16/14, 10:51 AM, "Andrew Phillips" <ap...@qrmedia.com> wrote:

>> - assertj-core
>> - assertj-guava
>>
>> Any objections?
>
>Sounds good to me. Do they bring in any libraries that may cause
>conflicts for our users..?
>
>ap

Re: Embracing AssertJ

[Andrew Phillips <ap...@qrmedia.com>]

> - assertj-core
> - assertj-guava
>
> Any objections?

Sounds good to me. Do they bring in any libraries that may cause  
conflicts for our users..?

ap