You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/04/27 08:02:29 UTC

[GitHub] [orc] coderex2522 commented on a diff in pull request #1099: ORC-1159: [C++] Fix crash when the last stripe is skipped

coderex2522 commented on code in PR #1099:
URL: https://github.com/apache/orc/pull/1099#discussion_r859489437


##########
c++/src/Reader.cc:
##########
@@ -1133,7 +1133,7 @@ namespace orc {
     if (currentRowInStripe == 0) {
       startNextStripe();
     }
-    uint64_t rowsToRead =
+    uint64_t rowsToRead = currentStripe >= lastStripe ? 0 :

Review Comment:
   @stiga-huang Thanks! I think this bug is mainly caused by the fact that the currentStripe variable is updated while the rowsInCurrentStripe variable is not updated at the same time. So would it be better to reset the rowsInCurrentStripe variable at line 1088?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org