You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "goodseeyou (via GitHub)" <gi...@apache.org> on 2023/11/29 15:49:13 UTC
[PR] Correct path of default log4j configures [pinot]
goodseeyou opened a new pull request, #12069:
URL: https://github.com/apache/pinot/pull/12069
This PR is to correct default configure path for log4j in helm chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Correct path of default log4j configures [pinot]
Posted by "goodseeyou (via GitHub)" <gi...@apache.org>.
goodseeyou commented on PR #12069:
URL: https://github.com/apache/pinot/pull/12069#issuecomment-1832180673
Any instruction to add labels? If it's necessary. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Correct path of default log4j configures [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #12069:
URL: https://github.com/apache/pinot/pull/12069#discussion_r1412697283
##########
helm/pinot/values.yaml:
##########
@@ -112,7 +112,7 @@ controller:
jvmOpts: "-XX:ActiveProcessorCount=2 -Xms256M -Xmx1G -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -Xlog:gc*:file=/opt/pinot/gc-pinot-controller.log"
- log4j2ConfFile: /opt/pinot/etc/config/pinot-controller-log4j2.xml
+ log4j2ConfFile: /opt/pinot/etc/conf/pinot-controller-log4j2.xml
Review Comment:
nvm i think it is from https://github.com/apache/pinot/blob/99d34e05e0fbe287df9fdabe1237b78459ae3e93/docker/images/pinot/Dockerfile#L45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Correct path of default log4j configures [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #12069:
URL: https://github.com/apache/pinot/pull/12069#discussion_r1412696798
##########
helm/pinot/values.yaml:
##########
@@ -112,7 +112,7 @@ controller:
jvmOpts: "-XX:ActiveProcessorCount=2 -Xms256M -Xmx1G -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -Xlog:gc*:file=/opt/pinot/gc-pinot-controller.log"
- log4j2ConfFile: /opt/pinot/etc/config/pinot-controller-log4j2.xml
+ log4j2ConfFile: /opt/pinot/etc/conf/pinot-controller-log4j2.xml
Review Comment:
which configuration stated it should be `conf` instead of `config` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Correct path of default log4j configures [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12069:
URL: https://github.com/apache/pinot/pull/12069#issuecomment-1836993693
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12069?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`c57117a`)](https://app.codecov.io/gh/apache/pinot/commit/c57117a7503aa2fd0b9a7d3bd2de19f92d49ad9b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 0.00% compared to head [(`99d34e0`)](https://app.codecov.io/gh/apache/pinot/pull/12069?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.70%.
> Report is 5 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #12069 +/- ##
=============================================
+ Coverage 0.00% 46.70% +46.70%
- Complexity 6 945 +939
=============================================
Files 2314 1792 -522
Lines 126078 94138 -31940
Branches 19524 15212 -4312
=============================================
+ Hits 6 43967 +43961
+ Misses 126072 47040 -79032
- Partials 0 3131 +3131
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.70% <ø> (+46.70%)` | :arrow_up: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.70% <ø> (?)` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.70% <ø> (+46.70%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.70% <ø> (?)` | |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.70% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12069?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Correct path of default log4j configures [pinot]
Posted by "goodseeyou (via GitHub)" <gi...@apache.org>.
goodseeyou commented on code in PR #12069:
URL: https://github.com/apache/pinot/pull/12069#discussion_r1412698217
##########
helm/pinot/values.yaml:
##########
@@ -112,7 +112,7 @@ controller:
jvmOpts: "-XX:ActiveProcessorCount=2 -Xms256M -Xmx1G -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -Xlog:gc*:file=/opt/pinot/gc-pinot-controller.log"
- log4j2ConfFile: /opt/pinot/etc/config/pinot-controller-log4j2.xml
+ log4j2ConfFile: /opt/pinot/etc/conf/pinot-controller-log4j2.xml
Review Comment:
here is config located in image I found
https://github.com/apache/pinot/tree/master/docker/images/pinot/etc/conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Correct path of default log4j configures [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #12069:
URL: https://github.com/apache/pinot/pull/12069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Correct path of default log4j configures [pinot]
Posted by "goodseeyou (via GitHub)" <gi...@apache.org>.
goodseeyou commented on code in PR #12069:
URL: https://github.com/apache/pinot/pull/12069#discussion_r1412698476
##########
helm/pinot/values.yaml:
##########
@@ -112,7 +112,7 @@ controller:
jvmOpts: "-XX:ActiveProcessorCount=2 -Xms256M -Xmx1G -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -Xlog:gc*:file=/opt/pinot/gc-pinot-controller.log"
- log4j2ConfFile: /opt/pinot/etc/config/pinot-controller-log4j2.xml
+ log4j2ConfFile: /opt/pinot/etc/conf/pinot-controller-log4j2.xml
Review Comment:
I guess the configuration for conf path is from here
https://github.com/apache/pinot/blob/master/pinot-distribution/pinot-assembly.xml#L243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org