[GitHub] [hadoop] sahilTakiar commented on issue #1948: HADOOP-16855. wildfly classpath/loading issues

[GitBox <gi...@apache.org>]

sahilTakiar commented on issue #1948: HADOOP-16855. wildfly classpath/loading issues
URL: https://github.com/apache/hadoop/pull/1948#issuecomment-612146200
 
 
   I don't agree with this approach.
   
   > and in openssl mode, the s3a binding explicitly catches
   > these failures and handles too
   
   Why? The whole point of openssl mode is that if you enable it, you want the code to fail if openssl cannot be setup. The point of default mode is that it should be best effort.
   
   > Without that, it is utterly superfluous and simply any other source
   > of class path dependency and stack trace issues.
   
   Not sure I understand the concern with the classpath issues. Sure, wildfly is another dependency, but it has no transitive dependencies, so not sure what the harm is with including it. It doesn't do any weird shading of other dependencies either. This also forces users to pick which version of wildfly to use, rather than S3A saying we support version 'x.y.z'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org