You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2023/10/04 09:02:49 UTC

[PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

raboof opened a new pull request, #554:
URL: https://github.com/apache/kafka-site/pull/554

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on code in PR #554:
URL: https://github.com/apache/kafka-site/pull/554#discussion_r1345468001


##########
project-security.html:
##########
@@ -35,6 +35,22 @@ <h1 class="content-title">Kafka security</h1>
 		<p>
                         For a list of security issues fixed in released versions of Apache Kafka, see <a href="/cve-list">CVE list</a>.
 		</p>
+		<h2>Advisories for dependencies</h2>
+		<p>
+			Many organizations use 'security scanning' tools to detect components for which advisories exist. While we generally encourage using such tools, since they are an important way users are notified of risks, our experience is that they produce a lot of false positives: when a dependency of Kafka contains a vulnerability, it is likely Kafka is using it in a way that is not affected. As such, we do not consider the fact that an advisory has been published for a Kafka dependency sensitive. Only when additional analysis confirms Kafka is affected by the problem, we ask you to report this finding privately through <a href="mailto:security@kafka.apache.org?Subject=[SECURITY] My security issue" target="_top">security@kafka.apache.org</a>.

Review Comment:
   I would be more comfortable if we add something like "if you are unsure about impact to Kafka, err on the side of reporting". Asking this because users in the community may not be familiar with breadth of components in Kafka code base to make a call on impact.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #554:
URL: https://github.com/apache/kafka-site/pull/554#issuecomment-1746461093

   cc: @mimaison @ijuma @showuon, I would also solicit your opinion on this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #554:
URL: https://github.com/apache/kafka-site/pull/554#issuecomment-2173755020

   @raboof @divijvaidya -- What is the status of this PR? Seems nothing happened for a while. Do we still plant to get this merged, or should we close it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #554:
URL: https://github.com/apache/kafka-site/pull/554#discussion_r1345492786


##########
project-security.html:
##########
@@ -35,6 +35,22 @@ <h1 class="content-title">Kafka security</h1>
 		<p>
                         For a list of security issues fixed in released versions of Apache Kafka, see <a href="/cve-list">CVE list</a>.
 		</p>
+		<h2>Advisories for dependencies</h2>
+		<p>
+			Many organizations use 'security scanning' tools to detect components for which advisories exist. While we generally encourage using such tools, since they are an important way users are notified of risks, our experience is that they produce a lot of false positives: when a dependency of Kafka contains a vulnerability, it is likely Kafka is using it in a way that is not affected. As such, we do not consider the fact that an advisory has been published for a Kafka dependency sensitive. Only when additional analysis confirms Kafka is affected by the problem, we ask you to report this finding privately through <a href="mailto:security@kafka.apache.org?Subject=[SECURITY] My security issue" target="_top">security@kafka.apache.org</a>.

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #554:
URL: https://github.com/apache/kafka-site/pull/554#issuecomment-2230721857

   I feel comfortable with the current wording on this PR. Will keep this open for another 3 days for others to chime in, else I will merge this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "bmscomp (via GitHub)" <gi...@apache.org>.
bmscomp commented on PR #554:
URL: https://github.com/apache/kafka-site/pull/554#issuecomment-1746451332

   Thanks @raboof  , can you put a description for detailing the purpose of this pull request ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #554:
URL: https://github.com/apache/kafka-site/pull/554#discussion_r1345493725


##########
project-security.html:
##########
@@ -35,6 +35,22 @@ <h1 class="content-title">Kafka security</h1>
 		<p>
                         For a list of security issues fixed in released versions of Apache Kafka, see <a href="/cve-list">CVE list</a>.
 		</p>
+		<h2>Advisories for dependencies</h2>
+		<p>
+			Many organizations use 'security scanning' tools to detect components for which advisories exist. While we generally encourage using such tools, since they are an important way users are notified of risks, our experience is that they produce a lot of false positives: when a dependency of Kafka contains a vulnerability, it is likely Kafka is using it in a way that is not affected. As such, we do not consider the fact that an advisory has been published for a Kafka dependency sensitive. Only when additional analysis confirms Kafka is affected by the problem, we ask you to report this finding privately through <a href="mailto:security@kafka.apache.org?Subject=[SECURITY] My security issue" target="_top">security@kafka.apache.org</a>.

Review Comment:
   I'm happy to adapt the wording - of course it's up to you as PMC to decide how you want to deal with such cases.
   
   For context: since anyone can easily run a dependency scanner, it's been our general policy to consider the mere fact that an advisory exists for a dependency already public knowledge. If a user is unsure about the impact, that doesn't really introduce any new information, so private reporting might not yet be necessary at that point.
   
   I now changed the wording from "Only when additional analysis confirms Kafka is affected" to "Only when additional analysis suggests Kafka may be affected' - let me know if you'd like to see a stronger bias towards private reporting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya merged PR #554:
URL: https://github.com/apache/kafka-site/pull/554


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: document how we deal with advisories for dependencies [kafka-site]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #554:
URL: https://github.com/apache/kafka-site/pull/554#issuecomment-1746475927

   > Thanks @raboof , can you put a description for detailing the purpose of this pull request ?
   
   (updated the commit and PR message)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org