You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2020/03/02 19:32:22 UTC
[Impala-ASF-CR] IMPALA-4080 [part 6]: Move codegen from join's exec node to plan node and from data sinks to their config classes
Hello Daniel Becker, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15322
to look at the new patch set (#2).
Change subject: IMPALA-4080 [part 6]: Move codegen from join's exec node to plan node and from data sinks to their config classes
......................................................................
IMPALA-4080 [part 6]: Move codegen from join's exec node to plan node
and from data sinks to their config classes
This patch moves the code responsible for codegening from partitioned
hash join's exec node to plan node and from all data sinks to their
respective config classes.
Testing:
Manually verified that codegen works for all modified exec nodes and
data sinks.
Ran all exhaustive tests successfully.
Change-Id: I8fe54b4040d6e3c2fc224f7cd6c8c0bfe813707a
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/blocking-join-node.h
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/filter-context.cc
M be/src/exec/filter-context.h
M be/src/exec/grouping-aggregator.cc
M be/src/exec/nested-loop-join-node.cc
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/exec/partitioned-hash-join-builder.h
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/partitioned-hash-join-node.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/krpc-data-stream-sender.cc
M be/src/runtime/krpc-data-stream-sender.h
M be/src/runtime/runtime-state.h
16 files changed, 281 insertions(+), 190 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/15322/2
--
To view, visit http://gerrit.cloudera.org:8080/15322
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8fe54b4040d6e3c2fc224f7cd6c8c0bfe813707a
Gerrit-Change-Number: 15322
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>