You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos ReviewBot <re...@mesos.apache.org> on 2015/09/01 00:51:31 UTC
Re: Review Request 37968: Add more comments for why not using const
reference for some functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37968/#review97184
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37968]
All tests passed.
- Mesos ReviewBot
On Aug. 31, 2015, 9:25 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37968/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 9:25 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-3344
> https://issues.apache.org/jira/browse/MESOS-3344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add more comments for why not using const reference for some functions
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 1cf6dd18aa163688d6c8f3a6d33eacad3918015d
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp 68fc1fd179ee51fc5de0452c0f2ea3d354e0567f
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 01e59de466496dec9367ad6f48538327f53a7e18
>
> Diff: https://reviews.apache.org/r/37968/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>