You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/05/21 14:35:21 UTC

[GitHub] [commons-configuration] garydgregory commented on pull request #182: CONFIGURATION-764: Single Variable Interpolation

garydgregory commented on PR #182:
URL: https://github.com/apache/commons-configuration/pull/182#issuecomment-1133644573

   > @garydgregory, do you have any objections to this being merged?
   
   It might be ok but the single variable check will fail if a variable default value contains the end marker (escaped). Maybe the isSingleVariable method should document that this is only a simple attempt at optimization?
   
   The larger issue is that we have interpolation code all over in Apache projects. I'm trying to standardize on the Commons Text implementation but that implementation is not perfect either...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org