[GitHub] [helix] qqu0127 commented on pull request #2176: Wire in the logic for TaskExecutor reset timeout parameter

[GitBox <gi...@apache.org>]

qqu0127 commented on PR #2176:
URL: https://github.com/apache/helix/pull/2176#issuecomment-1184956702

   > You'll need to modify more logic to enable the constructor with both zk address and helix manager property. Please take a look at this [PR](https://github.com/apache/helix/pull/2137), its purpose was to add a constructor like that.
   
   Thanks @mgao0 for the pointer. Is this the same thing Neal mentioned? I feel if we make sure `_zkConnectionConfig` and `_zkClientConfig` are null in `HelixManagerProperty`, while a valid zkAddr is provided, we should be good to go. Could you please confirm?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org