You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zy...@apache.org on 2014/01/06 10:06:04 UTC
git commit: TS-2469: remove libreadline which is gpl licensed
Updated Branches:
refs/heads/master 024db4624 -> 3344fdfc7
TS-2469: remove libreadline which is gpl licensed
Signed-off-by: Zhao Yongming <mi...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/3344fdfc
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/3344fdfc
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/3344fdfc
Branch: refs/heads/master
Commit: 3344fdfc747470cf4f40ce98afc99191c67565e2
Parents: 024db46
Author: Ben Aitchison <be...@meh.net.nz>
Authored: Mon Jan 6 16:39:48 2014 +0800
Committer: Zhao Yongming <mi...@gmail.com>
Committed: Mon Jan 6 16:43:02 2014 +0800
----------------------------------------------------------------------
CHANGES | 3 +++
build/ax_lib_readline.m4 | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 8a1c2d0..be012eb 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
-*- coding: utf-8 -*-
Changes with Apache Traffic Server 4.2.0
+ *) [TS-2469] remove libreadline which is gpl licensed.
+ Author: Ben Aitchison <be...@meh.net.nz>
+
*) [TS-2235] url_print should NOT output "?" for empty query string,
fix two remains.
Author: Yu Qing
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/build/ax_lib_readline.m4
----------------------------------------------------------------------
diff --git a/build/ax_lib_readline.m4 b/build/ax_lib_readline.m4
index 37a02a4..1af80b2 100644
--- a/build/ax_lib_readline.m4
+++ b/build/ax_lib_readline.m4
@@ -65,7 +65,7 @@ AC_DEFUN([AX_LIB_READLINE], [
AC_CACHE_CHECK([for a readline compatible library],
ax_cv_lib_readline, [
ORIG_LIBS="$LIBS"
- for readline_lib in readline edit editline; do
+ for readline_lib in edit editline; do
for termcap_lib in "" termcap curses ncurses; do
if test -z "$termcap_lib"; then
TRY_LIB="-l$readline_lib"
Re: git commit: TS-2469: remove libreadline which is gpl licensed
Posted by James Peach <jp...@apache.org>.
On Jan 7, 2014, at 7:24 AM, Yongming Zhao <mi...@gmail.com> wrote:
> according to http://www.apache.org/legal/3party.html#options-systemrequirements :
>> System Requirements
>>
>> If a PMC wishes to build a product that takes a core dependency on some third-party work that is only available under an excluded license, the PMC might consider whether the work can be used as a system requirement, rather than an internal part of the product. The drawback to this approach is that every new system requirement narrows the potential user base for the product. Each PMC is solely responsible for choosing an appropriate set of system requirements for its products; however, the following guidelines are recommended:
>>
>> • Clearly label each product's system requirements and their licenses on the main product page.
>> • Consider the project's implicit/explicit charter and intention of the board resolution that created the project when determining how the system requirements will affect the users.
>> • Provide a means, when practical, for users to substitute an alternative implementation for system requirements only available under excluded licenses (especially non-OSD licenses).
>
>
> I’d prefer to not link GPLed library if we have another alternate replacement, we have seen many works on OpenOffice.org for GPLed library replacement.
>
> I think it is safe to replace readline because the other two replacement is very often used too, that will make much dependency issue for our users.
That makes sense to me. I'm OK with the change, I mainly wanted to raise it on the mailing list to give the larger community an opportunity to chime in.
J
Re: git commit: TS-2469: remove libreadline which is gpl licensed
Posted by James Peach <jp...@apache.org>.
On Jan 7, 2014, at 7:24 AM, Yongming Zhao <mi...@gmail.com> wrote:
> according to http://www.apache.org/legal/3party.html#options-systemrequirements :
>> System Requirements
>>
>> If a PMC wishes to build a product that takes a core dependency on some third-party work that is only available under an excluded license, the PMC might consider whether the work can be used as a system requirement, rather than an internal part of the product. The drawback to this approach is that every new system requirement narrows the potential user base for the product. Each PMC is solely responsible for choosing an appropriate set of system requirements for its products; however, the following guidelines are recommended:
>>
>> • Clearly label each product's system requirements and their licenses on the main product page.
>> • Consider the project's implicit/explicit charter and intention of the board resolution that created the project when determining how the system requirements will affect the users.
>> • Provide a means, when practical, for users to substitute an alternative implementation for system requirements only available under excluded licenses (especially non-OSD licenses).
>
>
> I’d prefer to not link GPLed library if we have another alternate replacement, we have seen many works on OpenOffice.org for GPLed library replacement.
>
> I think it is safe to replace readline because the other two replacement is very often used too, that will make much dependency issue for our users.
That makes sense to me. I'm OK with the change, I mainly wanted to raise it on the mailing list to give the larger community an opportunity to chime in.
J
Re: git commit: TS-2469: remove libreadline which is gpl licensed
Posted by Yongming Zhao <mi...@gmail.com>.
according to http://www.apache.org/legal/3party.html#options-systemrequirements :
> System Requirements
>
> If a PMC wishes to build a product that takes a core dependency on some third-party work that is only available under an excluded license, the PMC might consider whether the work can be used as a system requirement, rather than an internal part of the product. The drawback to this approach is that every new system requirement narrows the potential user base for the product. Each PMC is solely responsible for choosing an appropriate set of system requirements for its products; however, the following guidelines are recommended:
>
> • Clearly label each product's system requirements and their licenses on the main product page.
> • Consider the project's implicit/explicit charter and intention of the board resolution that created the project when determining how the system requirements will affect the users.
> • Provide a means, when practical, for users to substitute an alternative implementation for system requirements only available under excluded licenses (especially non-OSD licenses).
I’d prefer to not link GPLed library if we have another alternate replacement, we have seen many works on OpenOffice.org for GPLed library replacement.
I think it is safe to replace readline because the other two replacement is very often used too, that will make much dependency issue for our users.
Yongming Zhao
赵永明
aka 永豪 yonghao@taobao.com
在 2014年1月7日，上午9:17，Ben <be...@meh.net.nz> 写道：
> On Mon, Jan 06, 2014 at 10:28:08AM -0800, James Peach wrote:
>
>> I'm not very comfortable with this change. I don't think it fixes anything and I don't think that we have a good idea on how this affects distributions and end users. I'm perfectly happy with preferring libedit to libreadline, but I'd like some more information about the impact of removing libreadline.
>
> To my mind if it breaks at compile time it's better than ending up with a binary that has incompatible licenses such as libssl and libreadline.
>
> I don't know what's common for checking that licenses are kept in check. But it's a problem faced by quite a lot of software.
>
> An example of which is:
>
> http://lwn.net/Articles/428111/
>
> With PostgreSQL also linking against readline and openssl in violation.
>
> I must admit i don't understand all the complications, but to my mind the less dangerous path is to just not link against GPL libraries for non GPL
> software, and not take unnecessary risks when libedit can acheive the desired functionality.
>
> That said libedit may not be supported everywhere. But if support is not found the code already supports just not supporting advanced line editing
> / history capabilities, which can be reenabled by adding libedit/libeditline.
>
> Ben.
Re: git commit: TS-2469: remove libreadline which is gpl licensed
Posted by Ben <be...@meh.net.nz>.
On Mon, Jan 06, 2014 at 10:28:08AM -0800, James Peach wrote:
> I'm not very comfortable with this change. I don't think it fixes anything and I don't think that we have a good idea on how this affects distributions and end users. I'm perfectly happy with preferring libedit to libreadline, but I'd like some more information about the impact of removing libreadline.
To my mind if it breaks at compile time it's better than ending up with a binary that has incompatible licenses such as libssl and libreadline.
I don't know what's common for checking that licenses are kept in check. But it's a problem faced by quite a lot of software.
An example of which is:
http://lwn.net/Articles/428111/
With PostgreSQL also linking against readline and openssl in violation.
I must admit i don't understand all the complications, but to my mind the less dangerous path is to just not link against GPL libraries for non GPL
software, and not take unnecessary risks when libedit can acheive the desired functionality.
That said libedit may not be supported everywhere. But if support is not found the code already supports just not supporting advanced line editing
/ history capabilities, which can be reenabled by adding libedit/libeditline.
Ben.
Re: git commit: TS-2469: remove libreadline which is gpl licensed
Posted by Phil Sorber <so...@apache.org>.
On Mon, Jan 6, 2014 at 11:28 AM, James Peach <jp...@apache.org> wrote:
> On Jan 6, 2014, at 1:06 AM, zym@apache.org wrote:
>
> > Updated Branches:
> > refs/heads/master 024db4624 -> 3344fdfc7
> >
> >
> > TS-2469: remove libreadline which is gpl licensed
> >
> > Signed-off-by: Zhao Yongming <mi...@gmail.com>
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/3344fdfc
> > Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/3344fdfc
> > Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/3344fdfc
> >
> > Branch: refs/heads/master
> > Commit: 3344fdfc747470cf4f40ce98afc99191c67565e2
> > Parents: 024db46
> > Author: Ben Aitchison <be...@meh.net.nz>
> > Authored: Mon Jan 6 16:39:48 2014 +0800
> > Committer: Zhao Yongming <mi...@gmail.com>
> > Committed: Mon Jan 6 16:43:02 2014 +0800
> >
> > ----------------------------------------------------------------------
> > CHANGES | 3 +++
> > build/ax_lib_readline.m4 | 2 +-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/CHANGES
> > ----------------------------------------------------------------------
> > diff --git a/CHANGES b/CHANGES
> > index 8a1c2d0..be012eb 100644
> > --- a/CHANGES
> > +++ b/CHANGES
> > @@ -1,6 +1,9 @@
> > -*- coding:
> utf-8 -*-
> > Changes with Apache Traffic Server 4.2.0
> >
> > + *) [TS-2469] remove libreadline which is gpl licensed.
> > + Author: Ben Aitchison <be...@meh.net.nz>
> > +
> > *) [TS-2235] url_print should NOT output "?" for empty query string,
> > fix two remains.
> > Author: Yu Qing
> >
> >
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/build/ax_lib_readline.m4
> > ----------------------------------------------------------------------
> > diff --git a/build/ax_lib_readline.m4 b/build/ax_lib_readline.m4
> > index 37a02a4..1af80b2 100644
> > --- a/build/ax_lib_readline.m4
> > +++ b/build/ax_lib_readline.m4
> > @@ -65,7 +65,7 @@ AC_DEFUN([AX_LIB_READLINE], [
> > AC_CACHE_CHECK([for a readline compatible library],
> > ax_cv_lib_readline, [
> > ORIG_LIBS="$LIBS"
> > - for readline_lib in readline edit editline; do
> > + for readline_lib in edit editline; do
> > for termcap_lib in "" termcap curses ncurses; do
> > if test -z "$termcap_lib"; then
> > TRY_LIB="-l$readline_lib"
>
> I'm not very comfortable with this change. I don't think it fixes anything
> and I don't think that we have a good idea on how this affects
> distributions and end users. I'm perfectly happy with preferring libedit to
> libreadline, but I'd like some more information about the impact of
> removing libreadline.
>
I agree with this. Preferring libedit seems to meet everyone's goals. We
could even take a further step and require a flag to allow it to link
against readline. So you effectively get a warning, which you can fix by
either installing libedit, or adding a flag to link against readline. That
would push people towards libedit about as hard as we could without making
our own product useless.
>
> J
>
Re: git commit: TS-2469: remove libreadline which is gpl licensed
Posted by Phil Sorber <so...@apache.org>.
On Mon, Jan 6, 2014 at 11:28 AM, James Peach <jp...@apache.org> wrote:
> On Jan 6, 2014, at 1:06 AM, zym@apache.org wrote:
>
> > Updated Branches:
> > refs/heads/master 024db4624 -> 3344fdfc7
> >
> >
> > TS-2469: remove libreadline which is gpl licensed
> >
> > Signed-off-by: Zhao Yongming <mi...@gmail.com>
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/3344fdfc
> > Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/3344fdfc
> > Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/3344fdfc
> >
> > Branch: refs/heads/master
> > Commit: 3344fdfc747470cf4f40ce98afc99191c67565e2
> > Parents: 024db46
> > Author: Ben Aitchison <be...@meh.net.nz>
> > Authored: Mon Jan 6 16:39:48 2014 +0800
> > Committer: Zhao Yongming <mi...@gmail.com>
> > Committed: Mon Jan 6 16:43:02 2014 +0800
> >
> > ----------------------------------------------------------------------
> > CHANGES | 3 +++
> > build/ax_lib_readline.m4 | 2 +-
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/CHANGES
> > ----------------------------------------------------------------------
> > diff --git a/CHANGES b/CHANGES
> > index 8a1c2d0..be012eb 100644
> > --- a/CHANGES
> > +++ b/CHANGES
> > @@ -1,6 +1,9 @@
> > -*- coding:
> utf-8 -*-
> > Changes with Apache Traffic Server 4.2.0
> >
> > + *) [TS-2469] remove libreadline which is gpl licensed.
> > + Author: Ben Aitchison <be...@meh.net.nz>
> > +
> > *) [TS-2235] url_print should NOT output "?" for empty query string,
> > fix two remains.
> > Author: Yu Qing
> >
> >
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/build/ax_lib_readline.m4
> > ----------------------------------------------------------------------
> > diff --git a/build/ax_lib_readline.m4 b/build/ax_lib_readline.m4
> > index 37a02a4..1af80b2 100644
> > --- a/build/ax_lib_readline.m4
> > +++ b/build/ax_lib_readline.m4
> > @@ -65,7 +65,7 @@ AC_DEFUN([AX_LIB_READLINE], [
> > AC_CACHE_CHECK([for a readline compatible library],
> > ax_cv_lib_readline, [
> > ORIG_LIBS="$LIBS"
> > - for readline_lib in readline edit editline; do
> > + for readline_lib in edit editline; do
> > for termcap_lib in "" termcap curses ncurses; do
> > if test -z "$termcap_lib"; then
> > TRY_LIB="-l$readline_lib"
>
> I'm not very comfortable with this change. I don't think it fixes anything
> and I don't think that we have a good idea on how this affects
> distributions and end users. I'm perfectly happy with preferring libedit to
> libreadline, but I'd like some more information about the impact of
> removing libreadline.
>
I agree with this. Preferring libedit seems to meet everyone's goals. We
could even take a further step and require a flag to allow it to link
against readline. So you effectively get a warning, which you can fix by
either installing libedit, or adding a flag to link against readline. That
would push people towards libedit about as hard as we could without making
our own product useless.
>
> J
>
Re: git commit: TS-2469: remove libreadline which is gpl licensed
Posted by James Peach <jp...@apache.org>.
On Jan 6, 2014, at 1:06 AM, zym@apache.org wrote:
> Updated Branches:
> refs/heads/master 024db4624 -> 3344fdfc7
>
>
> TS-2469: remove libreadline which is gpl licensed
>
> Signed-off-by: Zhao Yongming <mi...@gmail.com>
>
>
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/3344fdfc
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/3344fdfc
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/3344fdfc
>
> Branch: refs/heads/master
> Commit: 3344fdfc747470cf4f40ce98afc99191c67565e2
> Parents: 024db46
> Author: Ben Aitchison <be...@meh.net.nz>
> Authored: Mon Jan 6 16:39:48 2014 +0800
> Committer: Zhao Yongming <mi...@gmail.com>
> Committed: Mon Jan 6 16:43:02 2014 +0800
>
> ----------------------------------------------------------------------
> CHANGES | 3 +++
> build/ax_lib_readline.m4 | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/CHANGES
> ----------------------------------------------------------------------
> diff --git a/CHANGES b/CHANGES
> index 8a1c2d0..be012eb 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -1,6 +1,9 @@
> -*- coding: utf-8 -*-
> Changes with Apache Traffic Server 4.2.0
>
> + *) [TS-2469] remove libreadline which is gpl licensed.
> + Author: Ben Aitchison <be...@meh.net.nz>
> +
> *) [TS-2235] url_print should NOT output "?" for empty query string,
> fix two remains.
> Author: Yu Qing
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/build/ax_lib_readline.m4
> ----------------------------------------------------------------------
> diff --git a/build/ax_lib_readline.m4 b/build/ax_lib_readline.m4
> index 37a02a4..1af80b2 100644
> --- a/build/ax_lib_readline.m4
> +++ b/build/ax_lib_readline.m4
> @@ -65,7 +65,7 @@ AC_DEFUN([AX_LIB_READLINE], [
> AC_CACHE_CHECK([for a readline compatible library],
> ax_cv_lib_readline, [
> ORIG_LIBS="$LIBS"
> - for readline_lib in readline edit editline; do
> + for readline_lib in edit editline; do
> for termcap_lib in "" termcap curses ncurses; do
> if test -z "$termcap_lib"; then
> TRY_LIB="-l$readline_lib"
I'm not very comfortable with this change. I don't think it fixes anything and I don't think that we have a good idea on how this affects distributions and end users. I'm perfectly happy with preferring libedit to libreadline, but I'd like some more information about the impact of removing libreadline.
J
Re: git commit: TS-2469: remove libreadline which is gpl licensed
Posted by James Peach <jp...@apache.org>.
On Jan 6, 2014, at 1:06 AM, zym@apache.org wrote:
> Updated Branches:
> refs/heads/master 024db4624 -> 3344fdfc7
>
>
> TS-2469: remove libreadline which is gpl licensed
>
> Signed-off-by: Zhao Yongming <mi...@gmail.com>
>
>
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/3344fdfc
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/3344fdfc
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/3344fdfc
>
> Branch: refs/heads/master
> Commit: 3344fdfc747470cf4f40ce98afc99191c67565e2
> Parents: 024db46
> Author: Ben Aitchison <be...@meh.net.nz>
> Authored: Mon Jan 6 16:39:48 2014 +0800
> Committer: Zhao Yongming <mi...@gmail.com>
> Committed: Mon Jan 6 16:43:02 2014 +0800
>
> ----------------------------------------------------------------------
> CHANGES | 3 +++
> build/ax_lib_readline.m4 | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/CHANGES
> ----------------------------------------------------------------------
> diff --git a/CHANGES b/CHANGES
> index 8a1c2d0..be012eb 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -1,6 +1,9 @@
> -*- coding: utf-8 -*-
> Changes with Apache Traffic Server 4.2.0
>
> + *) [TS-2469] remove libreadline which is gpl licensed.
> + Author: Ben Aitchison <be...@meh.net.nz>
> +
> *) [TS-2235] url_print should NOT output "?" for empty query string,
> fix two remains.
> Author: Yu Qing
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/3344fdfc/build/ax_lib_readline.m4
> ----------------------------------------------------------------------
> diff --git a/build/ax_lib_readline.m4 b/build/ax_lib_readline.m4
> index 37a02a4..1af80b2 100644
> --- a/build/ax_lib_readline.m4
> +++ b/build/ax_lib_readline.m4
> @@ -65,7 +65,7 @@ AC_DEFUN([AX_LIB_READLINE], [
> AC_CACHE_CHECK([for a readline compatible library],
> ax_cv_lib_readline, [
> ORIG_LIBS="$LIBS"
> - for readline_lib in readline edit editline; do
> + for readline_lib in edit editline; do
> for termcap_lib in "" termcap curses ncurses; do
> if test -z "$termcap_lib"; then
> TRY_LIB="-l$readline_lib"
I'm not very comfortable with this change. I don't think it fixes anything and I don't think that we have a good idea on how this affects distributions and end users. I'm perfectly happy with preferring libedit to libreadline, but I'd like some more information about the impact of removing libreadline.
J