[GitHub] [flink] 1996fanrui commented on a diff in pull request #22845: [FLINK-32411][connector/common] Fix the bug about SourceCoordinator thread leaks

["1996fanrui (via GitHub)" <gi...@apache.org>]

1996fanrui commented on code in PR #22845:
URL: https://github.com/apache/flink/pull/22845#discussion_r1243180040


##########
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##########
@@ -270,8 +269,9 @@ public void start() throws Exception {
     @Override
     public void close() throws Exception {
         LOG.info("Closing SourceCoordinator for source {}.", operatorName);
+        closeQuietly(context);
         if (started) {
-            closeAll(asList(context, enumerator), Throwable.class);
+            closeQuietly(enumerator);

Review Comment:
   Thanks for the review, good catch! updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org