[jira] [Work logged] (BEAM-14121) Incorrect Spanner IO Request Count metrics

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-14121?focusedWorklogId=755273&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755273 ]

ASF GitHub Bot logged work on BEAM-14121:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 15:34
            Start Date: 11/Apr/22 15:34
    Worklog Time Spent: 10m 
      Work Description: asf-ci commented on PR #17335:
URL: https://github.com/apache/beam/pull/17335#issuecomment-1095205400

   Can one of the admins verify this patch?




Issue Time Tracking
-------------------

            Worklog Id:     (was: 755273)
    Remaining Estimate: 39h  (was: 39h 10m)
            Time Spent: 1h  (was: 50m)

> Incorrect Spanner IO Request Count metrics
> ------------------------------------------
>
>                 Key: BEAM-14121
>                 URL: https://issues.apache.org/jira/browse/BEAM-14121
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>    Affects Versions: 2.34.0
>            Reporter: Niel Markwick
>            Assignee: Niel Markwick
>            Priority: P2
>              Labels: google-cloud-spanner
>   Original Estimate: 40h
>          Time Spent: 1h
>  Remaining Estimate: 39h
>
> IO request count metrics calculated incorrectly for GCP Spanner
>  
> Resource ID is formulated incorrectly
> *Spanner Table:*
> {{//spanner.googleapis.com/projects/\{projectId}/{*}topics{*}/\{databaseId}/tables/\{tableId}}}
> should be
> {{//spanner.googleapis.com/projects/\{projectId}/instances/\{instanceId}/databases/\{databaseId}/tables/\{tableId}}}
> and is populated incorrectly – instance ID is used in place of tableID
> Spanner SQL Query:
> {{//spanner.googleapis.com/projects/\{projectId}/queries/\{queryName} }}
> {{should be}}
> {{{}//spanner.googleapis.com/projects/\{projectId}/{}}}{{{}instances/\{instanceId}/queries{}}}{{{}/\{queryName} {}}}
> and queryName is nullable which cause issued downstream
> this is not actually populated at all - queries are logged as reads on an instance. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)