You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/30 19:00:43 UTC

[GitHub] [incubator-druid] gianm commented on issue #8194: HllSketch Merge/Build BufferAggregators: Speed up init with prebuilt sketch.

gianm commented on issue #8194: HllSketch Merge/Build BufferAggregators: Speed up init with prebuilt sketch.
URL: https://github.com/apache/incubator-druid/pull/8194#issuecomment-516550416
 
 
   > I would think that a similar change should be made to HllSketchBuildBufferAggregator
   
   I just added that too, and updated the PR title accordingly.
   
   Btw, I couldn't share code for creating the prebuilt sketches, because init does not behave the same way in the two flavors. The "build" flavor initializes based on tgtHllType, but the "merge" flavor always initializes using HLL_8. Do you know why that is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org