You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/09/30 10:40:54 UTC

[GitHub] [systemds] sebwrede opened a new pull request #1074: Postprocess Privacy Constraints Before Lineage Cache

sebwrede opened a new pull request #1074:
URL: https://github.com/apache/systemds/pull/1074


   This PR will make sure that privacy constraints are propagated to output variables before the result of the instruction is cached. This is under the assumption that the caching does not only use the CPOperand outputs, but also uses the variables stored in the execution context. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] phaniarnab closed pull request #1074: Postprocess Privacy Constraints Before Lineage Cache

Posted by GitBox <gi...@apache.org>.
phaniarnab closed pull request #1074:
URL: https://github.com/apache/systemds/pull/1074


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] phaniarnab commented on pull request #1074: Postprocess Privacy Constraints Before Lineage Cache

Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #1074:
URL: https://github.com/apache/systemds/pull/1074#issuecomment-701931912


   What will happen if the result is reused from lineage cache? 
   I suggest a small test to check. You can enable lineage reuse by passing `-lineage reuse_full` option.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] sebwrede commented on pull request #1074: Postprocess Privacy Constraints Before Lineage Cache

Posted by GitBox <gi...@apache.org>.
sebwrede commented on pull request #1074:
URL: https://github.com/apache/systemds/pull/1074#issuecomment-702181150


   I have now added a test and put the postprocessing of privacy constraints outside the lineage cache if-block in ProgramBlock. In this way, the privacy constraints will be propagated even if the result has been read from the cache. 
   I needed to add a few lines which is also a part of [another pending PR](https://github.com/apache/systemds/pull/1066) to propagate the fine-grained constraints and to release matrix input. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] phaniarnab commented on pull request #1074: Postprocess Privacy Constraints Before Lineage Cache

Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #1074:
URL: https://github.com/apache/systemds/pull/1074#issuecomment-702183627


   Thanks. Looks good. 🦾 
   LGTM (if all the tests pass).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org