You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/27 01:09:20 UTC

[GitHub] [hbase] jojochuang opened a new pull request #1215: HBASE-23897. [OpenTracing] Add traces in Procedure V2.

jojochuang opened a new pull request #1215: HBASE-23897. [OpenTracing] Add traces in Procedure V2.
URL: https://github.com/apache/hbase/pull/1215
 
 
   Added basic trace spans in Procedure V2 framework.
   Added tests to ensure traces got connected correctly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1215: HBASE-23897. [OpenTracing] Add traces in Procedure V2.

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1215: HBASE-23897. [OpenTracing] Add traces in Procedure V2.
URL: https://github.com/apache/hbase/pull/1215#issuecomment-591753851
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 32s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  No case conflicting files found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 13 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 48s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 15s |  master passed  |
   | +1 :green_heart: |  compile  |   3m  6s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m 32s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 40s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   7m  1s |  master passed  |
   | +0 :ok: |  spotbugs  |   0m 27s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 41s |  branch/hbase-shaded no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 17s |  branch/hbase-shaded/hbase-shaded-client no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 13s |  branch/hbase-shaded/hbase-shaded-with-hadoop-check-invariants no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 15s |  branch/hbase-shaded/hbase-shaded-check-invariants no findbugs output file (findbugsXml.xml)  |
   | +0 :ok: |  findbugs  |   0m 26s |  branch/hbase-shaded/hbase-shaded-testing-util no findbugs output file (findbugsXml.xml)  |
   | -0 :warning: |  patch  |   2m 37s |  Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 28s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 12s |  root in the patch failed.  |
   | -1 :x: |  cc  |   0m 12s |  root in the patch failed.  |
   | -1 :x: |  javac  |   0m 12s |  root in the patch failed.  |
   | -1 :x: |  checkstyle  |   0m 10s |  The patch fails to run checkstyle in root  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m 11s |  The patch has no ill-formed XML file.  |
   | -1 :x: |  shadedjars  |   0m 28s |  patch has 11 errors when building our shaded downstream artifacts.  |
   | -1 :x: |  hadoopcheck  |   0m 12s |  The patch causes 10 errors with Hadoop v2.8.5.  |
   | -1 :x: |  hadoopcheck  |   0m 24s |  The patch causes 10 errors with Hadoop v2.9.2.  |
   | -1 :x: |  hadoopcheck  |   0m 35s |  The patch causes 10 errors with Hadoop v3.1.2.  |
   | -1 :x: |  hbaseprotoc  |   0m 13s |  hbase-shaded in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 16s |  root in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m  9s |  hbase-client in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m  9s |  hbase-common in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 10s |  hbase-external-blockcache in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 10s |  hbase-it in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 10s |  hbase-mapreduce in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m  9s |  hbase-procedure in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m  8s |  hbase-protocol-shaded in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 11s |  hbase-server in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m  9s |  hbase-shaded-client in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 10s |  hbase-shaded-testing-util in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m  9s |  hbase-zookeeper in the patch failed.  |
   | -1 :x: |  javadoc  |   0m 10s |  hbase-shaded in the patch failed.  |
   | -1 :x: |  javadoc  |   0m 12s |  root in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  hbase-client in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  8s |  hbase-common in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  hbase-external-blockcache in the patch failed.  |
   | -1 :x: |  javadoc  |   0m 10s |  hbase-it in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  hbase-mapreduce in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  hbase-procedure in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  hbase-protocol-shaded in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  hbase-server in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  8s |  hbase-shaded-client in the patch failed.  |
   | -1 :x: |  javadoc  |   0m 10s |  hbase-shaded-testing-util in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  8s |  hbase-zookeeper in the patch failed.  |
   | -1 :x: |  findbugs  |   0m 11s |  hbase-shaded in the patch failed.  |
   | -1 :x: |  findbugs  |   0m 12s |  root in the patch failed.  |
   | -1 :x: |  findbugs  |   0m  9s |  hbase-client in the patch failed.  |
   | -1 :x: |  findbugs  |   0m  9s |  hbase-common in the patch failed.  |
   | -1 :x: |  findbugs  |   0m  9s |  hbase-external-blockcache in the patch failed.  |
   | -1 :x: |  findbugs  |   0m  9s |  hbase-mapreduce in the patch failed.  |
   | -1 :x: |  findbugs  |   0m  9s |  hbase-procedure in the patch failed.  |
   | -1 :x: |  findbugs  |   0m  8s |  hbase-protocol-shaded in the patch failed.  |
   | -1 :x: |  findbugs  |   0m 10s |  hbase-server in the patch failed.  |
   | +0 :ok: |  findbugs  |   0m 11s |  hbase-shaded/hbase-shaded-check-invariants has no data from findbugs  |
   | -1 :x: |  findbugs  |   0m  9s |  hbase-shaded-client in the patch failed.  |
   | -1 :x: |  findbugs  |   0m  9s |  hbase-shaded-testing-util in the patch failed.  |
   | +0 :ok: |  findbugs  |   0m 11s |  hbase-shaded/hbase-shaded-with-hadoop-check-invariants has no data from findbugs  |
   | -1 :x: |  findbugs  |   0m  9s |  hbase-zookeeper in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 28s |  root in the patch failed.  |
   | -1 :x: |  asflicense  |   2m 37s |  The patch generated 3 ASF License warnings.  |
   |  |   |  70m 24s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1215 |
   | Optional Tests | dupname asflicense checkstyle xml javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti compile cc hbaseprotoc prototool |
   | uname | Linux e7b00fbc2d87 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1215/out/precommit/personality/provided.sh |
   | git revision | master / 3c3aae9a2f |
   | Default Java | 1.8.0_181 |
   | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-mvninstall-root.txt |
   | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-compile-root.txt |
   | cc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-compile-root.txt |
   | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-compile-root.txt |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1215/out/maven-patch-checkstyle-root.txt |
   | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-shadedjars.txt |
   | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javac-2.8.5.txt |
   | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javac-2.9.2.txt |
   | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javac-3.1.2.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-shaded.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-root.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-client.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-common.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-external-blockcache.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-it.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-mapreduce.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-procedure.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-protocol-shaded.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-server.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-shaded_hbase-shaded-client.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-shaded_hbase-shaded-testing-util.txt |
   | hbaseprotoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-hbaseprotoc-hbase-zookeeper.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-shaded.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-root.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-client.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-common.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-external-blockcache.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-it.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-mapreduce.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-procedure.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-protocol-shaded.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-server.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-shaded_hbase-shaded-client.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-shaded_hbase-shaded-testing-util.txt |
   | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-javadoc-hbase-zookeeper.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-shaded.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-root.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-client.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-common.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-external-blockcache.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-mapreduce.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-procedure.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-protocol-shaded.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-server.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-shaded_hbase-shaded-client.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-shaded_hbase-shaded-testing-util.txt |
   | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-findbugs-hbase-zookeeper.txt |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-unit-root.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/testReport/ |
   | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/artifact/out/patch-asflicense-problems.txt |
   | Max. process+thread count | 96 (vs. ulimit of 10000) |
   | modules | C: hbase-protocol hbase-shaded . hbase-client hbase-common hbase-external-blockcache hbase-it hbase-mapreduce hbase-procedure hbase-protocol-shaded hbase-server hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-zookeeper U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1215/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services