You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stanislav Ochotnicky (JIRA)" <ji...@codehaus.org> on 2010/09/29 14:02:32 UTC
[jira] Created: (MPLUGIN-173) Start using net.sf.jtidy artifact
with correct I/O encoding
Start using net.sf.jtidy artifact with correct I/O encoding
-----------------------------------------------------------
Key: MPLUGIN-173
URL: http://jira.codehaus.org/browse/MPLUGIN-173
Project: Maven 2.x Plugin Tools
Issue Type: Improvement
Components: API
Affects Versions: 2.6
Reporter: Stanislav Ochotnicky
Attachments: 0001-fix-for-new-jtidy.patch
Current 2.6 version uses jtidy:jtidy artifact which is not being developed anymore. net.sf.jtidy:jtidy artifact provides more features and is actively developed. This patch replaces old artifact with new one and fixes -api to not use deprecated functions for I/O encoding.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MPLUGIN-173) Start using net.sf.jtidy
artifact with correct I/O encoding
Posted by "Stanislav Ochotnicky (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251599#action_251599 ]
Stanislav Ochotnicky edited comment on MPLUGIN-173 at 1/14/11 6:36 AM:
-----------------------------------------------------------------------
Previously jtidy had:
{code}
/**
* CharEncoding
* @see org.w3c.tidy.Configuration#CharEncoding
*/
public void setCharEncoding(int charencoding)
{code}
That used Configuration.XXX constants for character encodings
now there is:
{code}
/**
* <code>input-encoding</code> the character encoding used for input.
* @param encoding a valid java encoding name
*/
public void setInputEncoding(String encoding)
{code}
So the patch shouldn't change anything to what was used previously. I don't see how this could cause any problems. Plus just few lines below there already is "UTF-8" used to decode byte-stream. Though suggestions to make it better are welcome of course...
was (Author: sochotnicky):
Previously jtidy had:
/**
* CharEncoding
* @see org.w3c.tidy.Configuration#CharEncoding
*/
public void setCharEncoding(int charencoding)
That used Configuration.XXX constants for character encodings
now there is:
/**
* <code>input-encoding</code> the character encoding used for input.
* @param encoding a valid java encoding name
*/
public void setInputEncoding(String encoding)
So the patch shouldn't change anything to what was used previously. I don't see how this could cause any problems. Plus just few lines below there already is "UTF-8" used to decode byte-stream. Though suggestions to make it better are welcome of course...
> Start using net.sf.jtidy artifact with correct I/O encoding
> -----------------------------------------------------------
>
> Key: MPLUGIN-173
> URL: http://jira.codehaus.org/browse/MPLUGIN-173
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.6
> Reporter: Stanislav Ochotnicky
> Attachments: 0001-fix-for-new-jtidy.patch
>
>
> Current 2.6 version uses jtidy:jtidy artifact which is not being developed anymore. net.sf.jtidy:jtidy artifact provides more features and is actively developed. This patch replaces old artifact with new one and fixes -api to not use deprecated functions for I/O encoding.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPLUGIN-173) Start using net.sf.jtidy artifact
with correct I/O encoding
Posted by "Anders Hammar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251610#action_251610 ]
Anders Hammar commented on MPLUGIN-173:
---------------------------------------
Yes, you're right. I went through the code a bit more thoroughly after writing the comment and was about to edit it as I realized I was wrong. The code should be alright, as UTF-8 is used consistently everywhere.
> Start using net.sf.jtidy artifact with correct I/O encoding
> -----------------------------------------------------------
>
> Key: MPLUGIN-173
> URL: http://jira.codehaus.org/browse/MPLUGIN-173
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.6
> Reporter: Stanislav Ochotnicky
> Attachments: 0001-fix-for-new-jtidy.patch
>
>
> Current 2.6 version uses jtidy:jtidy artifact which is not being developed anymore. net.sf.jtidy:jtidy artifact provides more features and is actively developed. This patch replaces old artifact with new one and fixes -api to not use deprecated functions for I/O encoding.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPLUGIN-173) Start using net.sf.jtidy artifact
with correct I/O encoding
Posted by "Mark Michaelis (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=258298#action_258298 ]
Mark Michaelis commented on MPLUGIN-173:
----------------------------------------
This issue also causes problems with Jetty for example which depends on Maven Plugin Tools API. See JETTY-1339 (also a workaround is stated there). Actually it would be better to resolve this issue in MPLUGIN as just exchanging dependencies from the outside might actually cause exceptions within the API.
> Start using net.sf.jtidy artifact with correct I/O encoding
> -----------------------------------------------------------
>
> Key: MPLUGIN-173
> URL: http://jira.codehaus.org/browse/MPLUGIN-173
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.6
> Reporter: Stanislav Ochotnicky
> Attachments: 0001-fix-for-new-jtidy.patch
>
>
> Current 2.6 version uses jtidy:jtidy artifact which is not being developed anymore. net.sf.jtidy:jtidy artifact provides more features and is actively developed. This patch replaces old artifact with new one and fixes -api to not use deprecated functions for I/O encoding.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPLUGIN-173) Start using net.sf.jtidy artifact
with correct I/O encoding
Posted by "Stanislav Ochotnicky (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251599#action_251599 ]
Stanislav Ochotnicky commented on MPLUGIN-173:
----------------------------------------------
Previously jtidy had:
/**
* CharEncoding
* @see org.w3c.tidy.Configuration#CharEncoding
*/
public void setCharEncoding(int charencoding)
That used Configuration.XXX constants for character encodings
now there is:
/**
* <code>input-encoding</code> the character encoding used for input.
* @param encoding a valid java encoding name
*/
public void setInputEncoding(String encoding)
So the patch shouldn't change anything to what was used previously. I don't see how this could cause any problems. Plus just few lines below there already is "UTF-8" used to decode byte-stream. Though suggestions to make it better are welcome of course...
> Start using net.sf.jtidy artifact with correct I/O encoding
> -----------------------------------------------------------
>
> Key: MPLUGIN-173
> URL: http://jira.codehaus.org/browse/MPLUGIN-173
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.6
> Reporter: Stanislav Ochotnicky
> Attachments: 0001-fix-for-new-jtidy.patch
>
>
> Current 2.6 version uses jtidy:jtidy artifact which is not being developed anymore. net.sf.jtidy:jtidy artifact provides more features and is actively developed. This patch replaces old artifact with new one and fixes -api to not use deprecated functions for I/O encoding.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MPLUGIN-173) Start using net.sf.jtidy artifact
with correct I/O encoding
Posted by "Anders Hammar (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251593#action_251593 ]
Anders Hammar commented on MPLUGIN-173:
---------------------------------------
I don't like how encoding is hard-coded in this patch.
> Start using net.sf.jtidy artifact with correct I/O encoding
> -----------------------------------------------------------
>
> Key: MPLUGIN-173
> URL: http://jira.codehaus.org/browse/MPLUGIN-173
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.6
> Reporter: Stanislav Ochotnicky
> Attachments: 0001-fix-for-new-jtidy.patch
>
>
> Current 2.6 version uses jtidy:jtidy artifact which is not being developed anymore. net.sf.jtidy:jtidy artifact provides more features and is actively developed. This patch replaces old artifact with new one and fixes -api to not use deprecated functions for I/O encoding.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MPLUGIN-173) Start using net.sf.jtidy artifact with
correct I/O encoding
Posted by "Stephen Connolly (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPLUGIN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephen Connolly closed MPLUGIN-173.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.8
r1133705
> Start using net.sf.jtidy artifact with correct I/O encoding
> -----------------------------------------------------------
>
> Key: MPLUGIN-173
> URL: http://jira.codehaus.org/browse/MPLUGIN-173
> Project: Maven 2.x Plugin Tools
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.6
> Reporter: Stanislav Ochotnicky
> Fix For: 2.8
>
> Attachments: 0001-fix-for-new-jtidy.patch
>
>
> Current 2.6 version uses jtidy:jtidy artifact which is not being developed anymore. net.sf.jtidy:jtidy artifact provides more features and is actively developed. This patch replaces old artifact with new one and fixes -api to not use deprecated functions for I/O encoding.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira