You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/10/08 19:34:19 UTC

Re: Review Request 23710: Add line comments end punctuation style rule

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23710/#review55831
-----------------------------------------------------------


Hey Tim, did you get to address Adam's comment on the off-by-one issue?

- Niklas Nielsen


On Aug. 25, 2014, 5:12 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23710/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 5:12 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/23710
> 
> 
> Diffs
> -----
> 
>   support/cpplint.patch 1dd69a03044c0c17ca4ee555c6c9d27ea043d4f0 
>   support/cpplint.py bfd3390002a680b07aa3fcf785279ad19625294b 
>   support/mesos-style.py d24cb11adc06bc0ebaaa206301616c8b597f09e8 
> 
> Diff: https://reviews.apache.org/r/23710/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>