You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/03/09 20:20:02 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Lunderberg opened a new pull request, #14261:
URL: https://github.com/apache/tvm/pull/14261

   Previously, the `attrs` field exists within the `relax::CallNode` object, and could be accessed through the Python FFI, but could neither be defined through TVMScript nor shown using the TVMScript printer.  This commit updates the parser and printer for a keyword argument `attrs` in `R.call_tir`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tqchen commented on pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14261:
URL: https://github.com/apache/tvm/pull/14261#issuecomment-1462882102

   Because call_tir follows a special semantics, we do not apply attrs to call_tir in general for now. This would help to reduce the complexity in analyzing the related pieces. 
   
   Most of the attrs are hidden under the more pythonic kwargs API that can be explicitly passed by the user
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14261:
URL: https://github.com/apache/tvm/pull/14261#issuecomment-1462713579

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] yongwww commented on pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on PR #14261:
URL: https://github.com/apache/tvm/pull/14261#issuecomment-1478217996

   @Lunderberg thanks for the great effort! Since call_tir and call_dps_packed are following special semantics, I think it would be good to handle it inside the callee.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Lunderberg commented on pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14261:
URL: https://github.com/apache/tvm/pull/14261#issuecomment-1481285832

   That makes sense, and closing this PR.  Thank you all for the feedback!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Hzfengsy commented on pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #14261:
URL: https://github.com/apache/tvm/pull/14261#issuecomment-1463173188

   Hi @Lunderberg, thanks for the PR.
   
   As @tqchen mentioned, `CallTIR` is designed without attrs since it's a particular semantics. I'm curious about the use case of CallTIR attrs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] psrivas2 commented on pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "psrivas2 (via GitHub)" <gi...@apache.org>.
psrivas2 commented on PR #14261:
URL: https://github.com/apache/tvm/pull/14261#issuecomment-1476302251

   Does this PR need to be closed or waiting for input from someone? @Lunderberg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Lunderberg commented on pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14261:
URL: https://github.com/apache/tvm/pull/14261#issuecomment-1478183568

   @psrivas2 Thank you for checking.  If there's feedback on whether this utility would be useful in other cases, that would be helpful.  If it would be useful elsewhere, I can rebase onto the most recent unity.  Otherwise, I can re-implement my use case using the `PrimFunc::attrs` inside the callee instead of the `CallNode::attrs` of the caller.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Lunderberg commented on pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #14261:
URL: https://github.com/apache/tvm/pull/14261#issuecomment-1463878840

   Thank you, and that's what I was less certain on, in terms of the intended use of `CallNode::attrs`.
   
   In this case, the attributes were used as a way to separate out an analysis pass which planned a series of layout changes that would be applied for each TIR PrimFunc, and an application pass which performed those changes.  While that use case is going to be obsoleted by a more general implementation that @psrivas2 is working on, I wanted to break out any useful utilities from that dev branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Lunderberg closed pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg closed pull request #14261: [Unity][TVMScript] Expose CallNode::attrs for CallTIR
URL: https://github.com/apache/tvm/pull/14261


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org