You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2017/01/24 10:41:42 UTC
[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/515
CB-12383 Fix cordova_plugins metadata definition
Define parent object first
[Jira issue](https://issues.apache.org/jira/browse/CB-12383)
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Tested on windows and android with this code:
```
onDeviceReady: function() {
this.receivedEvent('deviceready');
navigator.notification.alert(cordova.require("cordova/plugin_list").metadata);
},
```
### What does this PR do?
Makes `require("cordova/plugin_list").metadata` also available with browserify.
### What testing has been done on this change?
Manual tests, run cordova-lib auto tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-lib CB-12383
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #515
----
commit c23f20f3600330c722926e233c0a2dd893f8b25c
Author: daserge <v-...@microsoft.com>
Date: 2017-01-24T09:52:44Z
CB-12383 Fix cordova_plugins metadata definition
Define parent object first
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97738068
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi, pluginInfoProvider
// instead of generating intermediate file on FS
var cordova_plugins = new Readable();
cordova_plugins.push(
- 'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n' +
- 'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n', 'utf8');
+ 'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n' +
+ 'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n', 'utf8');
--- End diff --
So, if I understand correctly, the whole `module.exports` object was being rewritten, so `metadata` property was being lost, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #515: CB-12383 Fix cordova_plugins metadata definition
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/515
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97743108
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi, pluginInfoProvider
// instead of generating intermediate file on FS
var cordova_plugins = new Readable();
cordova_plugins.push(
- 'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n' +
- 'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n', 'utf8');
+ 'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n' +
+ 'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n', 'utf8');
--- End diff --
Cool, thanks for clarification
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #515: CB-12383 Fix cordova_plugins metadata definit...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/515#discussion_r97741534
--- Diff: cordova-lib/src/plugman/browserify.js ---
@@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi, pluginInfoProvider
// instead of generating intermediate file on FS
var cordova_plugins = new Readable();
cordova_plugins.push(
- 'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n' +
- 'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n', 'utf8');
+ 'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n' +
+ 'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n', 'utf8');
--- End diff --
Right. And the behavior differs for normal and browserify cases.
I.e. in normal case when we are injecting a script element the above code did not result in `module.exports` being overwritten.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org