You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/16 14:50:58 UTC

[GitHub] [kafka] ijuma opened a new pull request #10330: MINOR: Add toString to various Kafka Metrics classes

ijuma opened a new pull request #10330:
URL: https://github.com/apache/kafka/pull/10330


   This was useful while debugging a JDK 16 test failure, I noticed these
   were missing.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10330: MINOR: Add toString to various Kafka Metrics classes

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10330:
URL: https://github.com/apache/kafka/pull/10330#issuecomment-800363060


   @ijuma I can't think of any reason not to do this. This seems reasonable to have.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #10330: MINOR: Add toString to various Kafka Metrics classes

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #10330:
URL: https://github.com/apache/kafka/pull/10330


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10330: MINOR: Add toString to various Kafka Metrics classes

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10330:
URL: https://github.com/apache/kafka/pull/10330#issuecomment-800326915


   @dajac any reason not to do this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10330: MINOR: Add toString to various Kafka Metrics classes

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10330:
URL: https://github.com/apache/kafka/pull/10330#issuecomment-800596069


   Failures are unrelated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org