You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2021/08/13 15:54:21 UTC
[GitHub] [syncope] andrea-patricelli opened a new pull request #286: [SYNCOPE-1640] fixed removal of empty enumeration key on multivalue p…
andrea-patricelli opened a new pull request #286:
URL: https://github.com/apache/syncope/pull/286
…aram and enum schema definition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] andrea-patricelli commented on a change in pull request #286: [SYNCOPE-1640] fixed removal of empty enumeration key on multivalue p…
Posted by GitBox <gi...@apache.org>.
andrea-patricelli commented on a change in pull request #286:
URL: https://github.com/apache/syncope/pull/286#discussion_r688919617
##########
File path: client/console/src/main/java/org/apache/syncope/client/console/commons/PropertyList.java
##########
@@ -174,13 +174,11 @@ public static String getEnumValuesAsString(final List<String> enumerationValues)
final StringBuilder builder = new StringBuilder();
Review comment:
Sure, LGTM! It should work seamlessly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] andrea-patricelli merged pull request #286: [SYNCOPE-1640] fixed removal of empty enumeration key on multivalue p…
Posted by GitBox <gi...@apache.org>.
andrea-patricelli merged pull request #286:
URL: https://github.com/apache/syncope/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a change in pull request #286: [SYNCOPE-1640] fixed removal of empty enumeration key on multivalue p…
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on a change in pull request #286:
URL: https://github.com/apache/syncope/pull/286#discussion_r688917826
##########
File path: client/console/src/main/java/org/apache/syncope/client/console/commons/PropertyList.java
##########
@@ -174,13 +174,11 @@ public static String getEnumValuesAsString(final List<String> enumerationValues)
final StringBuilder builder = new StringBuilder();
Review comment:
Why not replacing the whole method with
```
return enumerationValues.stream().
map(v -> StringUtils.isBlank(v) ? StringUtils.EMPTY : v.trim()).
collect(Collectors.joining(SyncopeConstants.ENUM_VALUES_SEPARATOR));
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org