You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/11 23:01:59 UTC

[GitHub] [beam] apilloud commented on a change in pull request #11988: [BEAM-9179] Simple code cleanup for ZetaSqlUtils

apilloud commented on a change in pull request #11988:
URL: https://github.com/apache/beam/pull/11988#discussion_r439115905



##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlUtils.java
##########
@@ -54,27 +54,25 @@
   private ZetaSqlUtils() {}
 
   // Type conversion: ZetaSQL => Calcite
-  public static SqlTypeName zetaSqlTypeToCalciteTypeName(TypeKind zetaSqlType) {
-    switch (zetaSqlType) {
+  public static SqlTypeName zetaSqlTypeToCalciteTypeName(Type type) {
+    switch (type.getKind()) {
       case TYPE_INT64:
         return SqlTypeName.BIGINT;
-      case TYPE_NUMERIC:

Review comment:
       This is deleted, which doesn't match your no functional change description. What is going on here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org