[GitHub] [pulsar] jerrypeng commented on a change in pull request #6752: Support different docker images in Kubernetes runtime of Pulsar Functions

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #6752:
URL: https://github.com/apache/pulsar/pull/6752#discussion_r437621127



##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
##########
@@ -973,8 +982,18 @@ private V1PodSpec getPodSpec(List<String> instanceCommand, Function.Resources re
     V1Container getFunctionContainer(List<String> instanceCommand, Function.Resources resource) {
         final V1Container container = new V1Container().name(PULSARFUNCTIONS_CONTAINER_NAME);
 
-        // set up the container images
-        container.setImage(pulsarDockerImageName);
+        Function.FunctionDetails.Runtime runtime = instanceConfig.getFunctionDetails().getRuntime();
+
+        if (runtime == Function.FunctionDetails.Runtime.JAVA){

Review comment:
       I don't think this is a backwards compatible change.  Existing users would still be using "pulsarDockerImageName" and only that config will be set.  "pulsarDockerImageName" should still be the default config used for image name and the new configs can override it if set.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org