You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (Created) (JIRA)" <ji...@apache.org> on 2012/01/24 23:50:40 UTC
[jira] [Created] (HIVE-2746) Metastore client doesn't log properly
in case of connection failure to server
Metastore client doesn't log properly in case of connection failure to server
-----------------------------------------------------------------------------
Key: HIVE-2746
URL: https://issues.apache.org/jira/browse/HIVE-2746
Project: Hive
Issue Type: Bug
Components: Metastore
Affects Versions: 0.8.0
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2746) Metastore client doesn't log properly
in case of connection failure to server
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2746:
-----------------------------------
Attachment: hive-2746.patch
Patch with appropriate appropriate grant perms. Going to commit soon.
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch, HIVE-2746.D1395.2.patch, hive-2746.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2746) Metastore client doesn't log
properly in case of connection failure to server
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192758#comment-13192758 ]
Phabricator commented on HIVE-2746:
-----------------------------------
ashutoshc has commented on the revision "HIVE-2746 [jira] Metastore client doesn't log properly in case of connection failure to server".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:292 No, in the catch block above exception is only logged, not thrown, because thats within a for loop of retries. Connection may succeed in a retry. We can't throw exception there.
REVISION DETAIL
https://reviews.facebook.net/D1395
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2746) Metastore client doesn't log properly
in case of connection failure to server
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2746:
------------------------------
Attachment: HIVE-2746.D1395.1.patch
ashutoshc requested code review of "HIVE-2746 [jira] Metastore client doesn't log properly in case of connection failure to server".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2746
Corrected log message to print exception message instead of reference address.
LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1395
AFFECTED FILES
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2913/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2746) Metastore client doesn't log
properly in case of connection failure to server
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193621#comment-13193621 ]
Hudson commented on HIVE-2746:
------------------------------
Integrated in Hive-trunk-h0.21 #1221 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1221/])
HIVE-2746 : Metastore client doesn't log properly in case of connection failure to server (hashutosh)
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236025
Files :
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2746.D1395.1.patch, HIVE-2746.D1395.2.patch, hive-2746.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2746) Metastore client doesn't log properly
in case of connection failure to server
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2746:
-----------------------------------
Status: Patch Available (was: Open)
All the tests passed with latest patch except for insert2_overwrite_partitions.q which seems unrelated to this patch and randomly fails on trunk.
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch, HIVE-2746.D1395.2.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2746) Metastore client doesn't log
properly in case of connection failure to server
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193458#comment-13193458 ]
Phabricator commented on HIVE-2746:
-----------------------------------
cwsteinbach has accepted the revision "HIVE-2746 [jira] Metastore client doesn't log properly in case of connection failure to server".
+1
REVISION DETAIL
https://reviews.facebook.net/D1395
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch, HIVE-2746.D1395.2.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2746) Metastore client doesn't log properly
in case of connection failure to server
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2746:
------------------------------
Attachment: HIVE-2746.D1395.2.patch
ashutoshc updated the revision "HIVE-2746 [jira] Metastore client doesn't log properly in case of connection failure to server".
Reviewers: JIRA, cwsteinbach
Incorporated Carl's suggestions. Fixed indentation. Moved both setugi functionality as well as secure transport setup outside of for loop, since retrials are for transport.open() and that code doesn't belong in for loop.
REVISION DETAIL
https://reviews.facebook.net/D1395
AFFECTED FILES
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch, HIVE-2746.D1395.2.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2746) Metastore client doesn't log
properly in case of connection failure to server
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192771#comment-13192771 ]
Phabricator commented on HIVE-2746:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2746 [jira] Metastore client doesn't log properly in case of connection failure to server".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:292 Ok, but then shouldn't this block be moved above the preceding one where we try to set the ugi? If we're not connected won't the set_ugi operation fail anyway with a LoginException?
REVISION DETAIL
https://reviews.facebook.net/D1395
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2746) Metastore client doesn't log
properly in case of connection failure to server
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192750#comment-13192750 ]
Phabricator commented on HIVE-2746:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2746 [jira] Metastore client doesn't log properly in case of connection failure to server".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:292 Is there any point in trying to set the ugi if the connection failed? Maybe this should be raised directly from the catch block above?
REVISION DETAIL
https://reviews.facebook.net/D1395
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2746) Metastore client doesn't log
properly in case of connection failure to server
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192777#comment-13192777 ]
Phabricator commented on HIVE-2746:
-----------------------------------
cwsteinbach has commented on the revision "HIVE-2746 [jira] Metastore client doesn't log properly in case of connection failure to server".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:292 Ok, I think I'm getting confused by the inconsistent indentation in this method (can you fix that?). It looks to me like the block of code that attempts to set the ugi should be taken out of the for-loop and moved below the !isConnected check. Does that make sense? Otherwise we're just polluting the log with noise every time a connection attempt fails.
REVISION DETAIL
https://reviews.facebook.net/D1395
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2746.D1395.1.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2746) Metastore client doesn't log properly
in case of connection failure to server
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2746:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Status: Resolved (was: Patch Available)
Committed to trunk.
> Metastore client doesn't log properly in case of connection failure to server
> -----------------------------------------------------------------------------
>
> Key: HIVE-2746
> URL: https://issues.apache.org/jira/browse/HIVE-2746
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 0.8.0
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.9.0
>
> Attachments: HIVE-2746.D1395.1.patch, HIVE-2746.D1395.2.patch, hive-2746.patch
>
>
> LOG.error(e.getStackTrace()) in current code prints memory location of StackTraceElement[] instead of message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira