[jira] [Commented] (THRIFT-2843) Automake configure.ac has possible typo related to Java

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220975#comment-14220975 ] 

ASF GitHub Bot commented on THRIFT-2843:
----------------------------------------

GitHub user cash opened a pull request:

    https://github.com/apache/thrift/pull/279

    THRIFT-2843:Fixes typo in Automake configuration for checking java variable

    The current code is checking that $JAVAC is defined twice.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cash/thrift config_typo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit 6cca2524b1d40375b383abef09a76d272be310c5
Author: Cash Costello <ca...@jhuapl.edu>
Date:   2014-11-21T14:29:25Z

    THRIFT-2843:Fixes typo in Automake configuration for checking java variable

----


> Automake configure.ac has possible typo related to Java
> -------------------------------------------------------
>
>                 Key: THRIFT-2843
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2843
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>            Reporter: Cash Costello
>            Priority: Trivial
>
> Looks like it tests for the java compiler twice. I'm guessing the second test is unnecessary or should be a test for the Java runtime.
> {code}
> AX_THRIFT_LIB(java, [Java], yes)
> if test "$with_java" = "yes";  then
>   AX_JAVAC_AND_JAVA
>   AC_PATH_PROG([ANT], [ant])
>   AX_CHECK_ANT_VERSION($ANT, 1.7)
>   AC_SUBST(CLASSPATH)
>   AC_SUBST(ANT_FLAGS)
>   if test "x$JAVAC" != "x" && test "x$JAVAC" != "x" && test "x$ANT" != "x" ; then
>     have_java="yes"
>   fi
> fi
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)