[GitHub] [daffodil] dasmallwood commented on a change in pull request #601: Distinct return codes for CLI

[GitBox <gi...@apache.org>]

dasmallwood commented on a change in pull request #601:
URL: https://github.com/apache/daffodil/pull/601#discussion_r675697850



##########
File path: daffodil-cli/src/it/scala/org/apache/daffodil/CLI/Util.scala
##########
@@ -200,4 +203,25 @@ object Util {
     }
     inputFile
   }
+
+  def expectExitCode(expectedExitCode: ExitCode.Value, shell: Expect): Unit = {
+    val expectedCode = expectedExitCode.id
+
+    val keyWord = "EXITCODE:"
+    val exitCodeCmd = "echo " + keyWord + (if (Util.isWindows) "%errorlevel%" else "$?")
+    shell.sendLine(exitCodeCmd)
+    shell.expect(contains(keyWord))

Review comment:
       from running the tests manually i've seen the Expect operation fails due to timeout 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org