You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "iMashtak (via GitHub)" <gi...@apache.org> on 2023/04/26 16:08:53 UTC
[GitHub] [camel-website] iMashtak opened a new pull request, #998: Added support for tabs in asciidoc files
iMashtak opened a new pull request, #998:
URL: https://github.com/apache/camel-website/pull/998
Resolved https://github.com/apache/camel-website/issues/997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] github-actions[bot] commented on pull request #998: Added support for tabs in asciidoc files
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #998:
URL: https://github.com/apache/camel-website/pull/998#issuecomment-1524964877
🚀 Preview is available at https://pr-998--camel.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] github-actions[bot] commented on pull request #998: Added support for tabs in asciidoc files
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #998:
URL: https://github.com/apache/camel-website/pull/998#issuecomment-1527258085
🚀 Preview is available at https://pr-998--camel.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] iMashtak commented on a diff in pull request #998: Added support for tabs in asciidoc files
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on code in PR #998:
URL: https://github.com/apache/camel-website/pull/998#discussion_r1179436242
##########
package.json:
##########
@@ -35,6 +35,7 @@
"devDependencies": {
"@antora/cli": "^3.0.0",
"@antora/site-generator": "^3.0.0",
+ "@asciidoctor/tabs": "1.0.0-beta.3",
Review Comment:
According to docs: https://github.com/asciidoctor/asciidoctor-tabs/blob/main/docs/use-with-antora.adoc#generator
It adds special syntax feature, so as far as i understand, it requires to be here.
Anyway if i `yarn remove "@asciidoctor/tabs"` then, `./local-build.sh quick` (camel repo) fails with `Your application tried to access @asciidoctor/tabs, but it isn't declared in your dependencies;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] davsclaus commented on pull request #998: Added support for tabs in asciidoc files
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #998:
URL: https://github.com/apache/camel-website/pull/998#issuecomment-1533444012
@zregvart is this okay to merge. @iMashtak and if so, can you maybe do a PR for one of the existing components to show how to do this, and then we can use this as baseline for migrating docs to this style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] iMashtak commented on a diff in pull request #998: Added support for tabs in asciidoc files
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on code in PR #998:
URL: https://github.com/apache/camel-website/pull/998#discussion_r1179436242
##########
package.json:
##########
@@ -35,6 +35,7 @@
"devDependencies": {
"@antora/cli": "^3.0.0",
"@antora/site-generator": "^3.0.0",
+ "@asciidoctor/tabs": "1.0.0-beta.3",
Review Comment:
According to docs: https://github.com/asciidoctor/asciidoctor-tabs/blob/main/docs/use-with-antora.adoc#generator
It adds special syntax feature, so as far as i understand, it requires to be here.
Anyway if i `yarn remove "@asciidoctor/tabs"` then, `local-build.sh quick` fails with `Your application tried to access @asciidoctor/tabs, but it isn't declared in your dependencies;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a diff in pull request #998: Added support for tabs in asciidoc files
Posted by "zregvart (via GitHub)" <gi...@apache.org>.
zregvart commented on code in PR #998:
URL: https://github.com/apache/camel-website/pull/998#discussion_r1180082906
##########
package.json:
##########
@@ -35,6 +35,7 @@
"devDependencies": {
"@antora/cli": "^3.0.0",
"@antora/site-generator": "^3.0.0",
+ "@asciidoctor/tabs": "1.0.0-beta.3",
Review Comment:
Yes, you are correct, this also adds an Antora extension, missed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a diff in pull request #998: Added support for tabs in asciidoc files
Posted by "zregvart (via GitHub)" <gi...@apache.org>.
zregvart commented on code in PR #998:
URL: https://github.com/apache/camel-website/pull/998#discussion_r1178827278
##########
package.json:
##########
@@ -35,6 +35,7 @@
"devDependencies": {
"@antora/cli": "^3.0.0",
"@antora/site-generator": "^3.0.0",
+ "@asciidoctor/tabs": "1.0.0-beta.3",
Review Comment:
I don't think we need it here, only in the UI
##########
antora-ui-camel/public/_/partials/head-styles.hbs:
##########
@@ -1 +1,2 @@
- <link rel="stylesheet" href="{{uiRootPath}}/css/site-00b7d111da.css">
+ <link rel="stylesheet" href="{{uiRootPath}}/css/site-66db361433.css">
+ <link rel="stylesheet" href="{{{uiRootPath}}}/css/tabs.css">
Review Comment:
I don't think this is needed, `tabs.css` is included in the `site-*.css`
##########
antora-ui-camel/src/css/site.css:
##########
@@ -29,3 +29,4 @@
@import 'catalog.css';
@import 'sharingbuttons.css';
@import 'security.css';
+@import 'tabs.css'
Review Comment:
Try this instead, so we don't need to copy `tabs.css` from @asciidoctor/tabs
```suggestion
@import '@asciidoctor/tabs/dist/css/tabs.css'
```
##########
antora-ui-camel/src/css/tabs.css:
##########
@@ -0,0 +1,98 @@
+/*! Asciidoctor Tabs | Copyright (c) 2018-present Dan Allen | MIT License */
Review Comment:
Let's use `@import '@asciidoctor/tabs/...` from above so we don't need to vendor this file, keeping it here makes it prone to being stale when we upgrade the @asciidoctor/tabs dependency
##########
antora-ui-camel/src/partials/head-styles.hbs:
##########
@@ -1 +1,2 @@
<link rel="stylesheet" href="{{uiRootPath}}/css/site.css">
+ <link rel="stylesheet" href="{{{uiRootPath}}}/css/tabs.css">
Review Comment:
Should be included in the `site.css`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart merged pull request #998: Added support for tabs in asciidoc files
Posted by "zregvart (via GitHub)" <gi...@apache.org>.
zregvart merged PR #998:
URL: https://github.com/apache/camel-website/pull/998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] orpiske commented on pull request #998: Added support for tabs in asciidoc files
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #998:
URL: https://github.com/apache/camel-website/pull/998#issuecomment-1524771448
Wow, if it's going to look like on the issue, IMHO, it will look awesome. Great one @iMashtak!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] iMashtak commented on pull request #998: Added support for tabs in asciidoc files
Posted by "iMashtak (via GitHub)" <gi...@apache.org>.
iMashtak commented on PR #998:
URL: https://github.com/apache/camel-website/pull/998#issuecomment-1533466377
@davsclaus created PR: https://github.com/apache/camel/pull/9992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org