You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2021/06/18 03:13:52 UTC
[dubbo] branch master updated: optimize generic filter (#8067)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new b16a404 optimize generic filter (#8067)
b16a404 is described below
commit b16a40416c06dfbfa69c1b67102ad9cd0a51ab69
Author: 张志勇 <go...@163.com>
AuthorDate: Fri Jun 18 11:13:24 2021 +0800
optimize generic filter (#8067)
optimize generic filter
---
.../src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java
index 831c7a5..a94ce41 100644
--- a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java
+++ b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java
@@ -65,8 +65,11 @@ import static org.apache.dubbo.rpc.Constants.GENERIC_KEY;
*/
@Activate(group = CommonConstants.PROVIDER, order = -20000)
public class GenericFilter implements Filter, Filter.Listener {
+
private static final Logger logger = LoggerFactory.getLogger(GenericFilter.class);
+ private static final Gson gson = new Gson();
+
@Override
public Result invoke(Invoker<?> invoker, Invocation inv) throws RpcException {
if ((inv.getMethodName().equals($INVOKE) || inv.getMethodName().equals($INVOKE_ASYNC))
@@ -190,8 +193,10 @@ public class GenericFilter implements Filter, Filter.Listener {
}
private Object[] getGsonGenericArgs(final Object[] args, Type[] types) {
- Gson gson = new Gson();
return IntStream.range(0, args.length).mapToObj(i -> {
+ if (!(args[i] instanceof String)) {
+ throw new RpcException("When using GSON to deserialize generic dubbo request arguments, the arguments must be of type String");
+ }
String str = args[i].toString();
Type type = TypeToken.get(types[i]).getType();
try {