You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2016/08/29 13:01:51 UTC
[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/106
[CARBONDATA-160]Data mismatch issue in case of multiple segment with different dictionary key size
Problem:In case of multiple segment and each segment keygenertaor key size is not same in that case when we are converting the surrogate key to mdkey values which are not present in the older segments using keygenertaor in that case keygenerator is giving some values which is less than column cardinality
Solutions: Need add only those surrogate keys which is less than equal to cardinality of the segment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kumarvishal09/incubator-carbondata FilterQueryDataMismatchIssue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit d178cd1bc62062d57ab888b4ffbd16d728325ca1
Author: kumarvishal <ku...@gmail.com>
Date: 2016-08-29T12:55:46Z
Data Mismatch issue in filter query
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/106#discussion_r76785409
--- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java ---
@@ -623,9 +655,11 @@ public static DimColumnFilterInfo getFilterListForAllMembersRS(Expression expres
if (null != dimColumnFilterInfo) {
for (Integer surrogate : dimColumnFilterInfo.getFilterList()) {
try {
- keys[carbonDimension.getKeyOrdinal()] = surrogate;
- filterValuesList
- .add(getMaskedKey(rangesForMaskedByte, blockLevelKeyGenerator.generateKey(keys)));
+ if (surrogate <= dimColumnsCardinality[carbonDimension.getKeyOrdinal()]) {
+ keys[carbonDimension.getKeyOrdinal()] = surrogate;
+ filterValuesList
+ .add(getMaskedKey(rangesForMaskedByte, blockLevelKeyGenerator.generateKey(keys)));
+ }
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/106#discussion_r76784937
--- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java ---
@@ -57,7 +68,17 @@
import org.apache.carbondata.scan.expression.conditional.ListExpression;
import org.apache.carbondata.scan.expression.exception.FilterIllegalMemberException;
import org.apache.carbondata.scan.expression.exception.FilterUnsupportedException;
-import org.apache.carbondata.scan.filter.executer.*;
+import org.apache.carbondata.scan.filter.executer.AndFilterExecuterImpl;
--- End diff --
Use `import org.apache.carbondata.scan.filter.executer.*;`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/106#discussion_r76784836
--- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java ---
@@ -623,9 +655,11 @@ public static DimColumnFilterInfo getFilterListForAllMembersRS(Expression expres
if (null != dimColumnFilterInfo) {
for (Integer surrogate : dimColumnFilterInfo.getFilterList()) {
try {
- keys[carbonDimension.getKeyOrdinal()] = surrogate;
- filterValuesList
- .add(getMaskedKey(rangesForMaskedByte, blockLevelKeyGenerator.generateKey(keys)));
+ if (surrogate <= dimColumnsCardinality[carbonDimension.getKeyOrdinal()]) {
+ keys[carbonDimension.getKeyOrdinal()] = surrogate;
+ filterValuesList
+ .add(getMaskedKey(rangesForMaskedByte, blockLevelKeyGenerator.generateKey(keys)));
+ }
--- End diff --
Please break the loop if it greater since the surrogates are always in sorted order here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/106#discussion_r76785423
--- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java ---
@@ -23,7 +23,18 @@
import java.nio.ByteBuffer;
import java.nio.charset.Charset;
import java.text.SimpleDateFormat;
-import java.util.*;
+import java.util.ArrayList;
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #106: [CARBONDATA-160]Data mismatch issue ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/106#discussion_r76785449
--- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterUtil.java ---
@@ -57,7 +68,17 @@
import org.apache.carbondata.scan.expression.conditional.ListExpression;
import org.apache.carbondata.scan.expression.exception.FilterIllegalMemberException;
import org.apache.carbondata.scan.expression.exception.FilterUnsupportedException;
-import org.apache.carbondata.scan.filter.executer.*;
+import org.apache.carbondata.scan.filter.executer.AndFilterExecuterImpl;
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---