You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2018/09/20 17:13:10 UTC

[GitHub] keith-turner commented on a change in pull request #197: When using ACCUMULO_REPO, build with the appropriate Hadoop profile.

keith-turner commented on a change in pull request #197: When using ACCUMULO_REPO, build with the appropriate Hadoop profile.
URL: https://github.com/apache/fluo-uno/pull/197#discussion_r219246654
 
 

 ##########
 File path: bin/impl/fetch.sh
 ##########
 @@ -59,10 +59,14 @@ function fetch_accumulo() {
   fi
 
   if [[ -n "$ACCUMULO_REPO" ]]; then
+    declare -a maven_args=(-DskipTests -DskipFormat)
+    if [[ "${HADOOP_VERSION}" = 3.* ]]; then
+      maven_args=("${maven_args[@]}" '-Dhadoop.profile=3')
 
 Review comment:
   Accumulo 2 is Hadoop 3 only.  So this would be unnecessary, but I don't think it would hurt anything. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services